Stream: t-compiler

Topic: x.py test folder


varkor (May 10 2019 at 22:52, on Zulip):

why does ./x.py test src/test/ui/subfolder run every single ui test, rather than just those in the subfolder?

varkor (May 10 2019 at 22:53, on Zulip):

I have the feeling that, at one point, giving an exact path would only run that path, but maybe I'm imagining things

centril (May 10 2019 at 22:59, on Zulip):

@varkor you can use --test-args for now; supporting folders would be neat

varkor (May 10 2019 at 23:15, on Zulip):

yeah, I know about --test-args, but it seems unnecessary really

simulacrum (May 10 2019 at 23:16, on Zulip):

@varkor I think if you give the file path then it'll work but we don't support folders

simulacrum (May 10 2019 at 23:16, on Zulip):

really all of the filtering logic is highly ... questionable

varkor (May 10 2019 at 23:17, on Zulip):

@simulacrum: I've just noticed this

simulacrum (May 10 2019 at 23:17, on Zulip):

so in theory folder/**/*.rs if you use shell with that kind of expansion

varkor (May 10 2019 at 23:19, on Zulip):

ah, I'll give that a try

varkor (May 10 2019 at 23:22, on Zulip):

I've opened https://github.com/rust-lang/rust/issues/60718, as I didn't see a pre-existing issue

varkor (May 10 2019 at 23:30, on Zulip):

well, I have a very simple fix for it that works for me

varkor (May 10 2019 at 23:30, on Zulip):

I'm not quite sure how it's interacting with --test-args

varkor (May 10 2019 at 23:31, on Zulip):

but who needs --test-args with this anyway

centril (May 10 2019 at 23:31, on Zulip):

@varkor don't you dare take away --test-args :P

varkor (May 10 2019 at 23:33, on Zulip):

oh, I see — if a full path is specified, it overrides --test-args

varkor (May 10 2019 at 23:40, on Zulip):

are you supposed to be able to specify multiple --test-args?

centril (May 10 2019 at 23:43, on Zulip):

@varkor did you try?

varkor (May 10 2019 at 23:43, on Zulip):

it seems the second one is ignored

varkor (May 10 2019 at 23:43, on Zulip):

just wanted to make sure that was everyone else's understanding

centril (May 10 2019 at 23:43, on Zulip):

@varkor software...

varkor (May 10 2019 at 23:43, on Zulip):

it means that specifying a subfolder will mean --test-args is ignored

varkor (May 10 2019 at 23:43, on Zulip):

but it's still an improvement over before

varkor (May 10 2019 at 23:43, on Zulip):

might quickly look into fixing that too

Last update: Nov 22 2019 at 05:55UTC