Stream: t-compiler

Topic: rustdoc bisection #61560


lqd (Oct 04 2019 at 10:22, on Zulip):

hey @pnkfelix , re this, do you want me to extract the doctests and bisect their code to see the commits which do change resolution wrt extern crate and the likes ?
the TLDR of this issue is: there were some rustc bugs which seem fixed, there are invalid tests, there were some rustdoc changes which started detecting these invalid tests, and there might still be a miscommunication between rustdoc and rustc wrt the soft_unstable lint

lqd (Oct 04 2019 at 10:23, on Zulip):

since they're now fixed I don't think we really need to, but I'll extract the soft_unstable piece of code and post it on the tracking issue

lqd (Oct 04 2019 at 10:29, on Zulip):

soft_unstable seems deny by default, but the error message is

error: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable
 --> src/lib.rs:384:7
  |
9 |     #[bench]
  |       ^^^^^
  |
  = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
  = note: for more information, see issue #64266 <https://github.com/rust-lang/rust/issues/64266>

so maybe it's not a miscommunication, but just the message confusing me

lqd (Oct 04 2019 at 10:31, on Zulip):

let me know if we need to do more testing

pnkfelix (Oct 04 2019 at 12:06, on Zulip):

maybe I misunderstood what happened here

pnkfelix (Oct 04 2019 at 12:07, on Zulip):

I had thought the issue was now hypothesized to be: There was no actual changes to resolution (we think) -- instead, a change to the doc-comment parser used by rustdoc caused it to start picking up tests that it wasn't picking up before,

pnkfelix (Oct 04 2019 at 12:07, on Zulip):

and some of those tests were buggy

pnkfelix (Oct 04 2019 at 12:07, on Zulip):

but those buggy tests were skipped (and thus silently accepted) in the past by crater

pnkfelix (Oct 04 2019 at 12:08, on Zulip):

which means I don't think there's any follow-up work for the rustc team to do. The only questions I could imagine are whether the rustdoc team wants/needs to do anything to "address" this

pnkfelix (Oct 04 2019 at 12:08, on Zulip):

(I suspect the answer at this point is "there's no value in going back to the old parser, or even trying to warning-cycle this change" -- but its not my decision to make, I think.)

lqd (Oct 04 2019 at 12:08, on Zulip):

there are many crates in that issue and that describes most of them yes, however some of the code which was ignored and unignored seemed to showcase rustc issues, which seemed either known, or have since been fixed

pnkfelix (Oct 04 2019 at 12:09, on Zulip):

hmm

lqd (Oct 04 2019 at 12:09, on Zulip):

the other issue which could be a duplicate, and mentions the new test detection behaviour also mentions what you say, unlikely to rollback as it fixed other issues, but I don't know

pnkfelix (Oct 04 2019 at 12:09, on Zulip):

If it seems to you that all of the rustc issues that have been identified this way are all already known and/or fixed

pnkfelix (Oct 04 2019 at 12:10, on Zulip):

then I still don't think there's any follow-up work for rustc team?

pnkfelix (Oct 04 2019 at 12:10, on Zulip):

Or is your point that you want to know how we can determine

pnkfelix (Oct 04 2019 at 12:10, on Zulip):

if we need to look more deeply or not?

lqd (Oct 04 2019 at 12:10, on Zulip):

I _could_ bisect those if you want, but since they seem fixed I'm not sure we need to

pnkfelix (Oct 04 2019 at 12:10, on Zulip):

yeah I don't think we need to do that at this point

pnkfelix (Oct 04 2019 at 12:11, on Zulip):

Now I understand your Q

lqd (Oct 04 2019 at 12:11, on Zulip):

that is, I expect bisection to point to these known fixed issues

lqd (Oct 04 2019 at 12:11, on Zulip):

the only new information I had was discovering a deny lint had a lint-like message and that's it

pnkfelix (Oct 04 2019 at 12:11, on Zulip):

Right. The main benefit I could see from bisection would be to double check if the problems being fixed here are actually covered by whatever tests were added when the relevant bugs were fixed.

pnkfelix (Oct 04 2019 at 12:12, on Zulip):

(as in, there might be E-needs-test cases here)

pnkfelix (Oct 04 2019 at 12:12, on Zulip):

but I don't think its worth the effort

pnkfelix (Oct 04 2019 at 12:12, on Zulip):

we have got a lot of other bugs that I think deserve attention

lqd (Oct 04 2019 at 12:12, on Zulip):

alright, I agree :)

lqd (Oct 04 2019 at 12:14, on Zulip):

I think we can close this one then, the "rustdoc changing behaviour" problem is probably for the better and "tracked" in another T-rustdoc issue #61562

pnkfelix (Oct 04 2019 at 12:20, on Zulip):

sounds good to me

lqd (Oct 04 2019 at 12:29, on Zulip):

done

Last update: Nov 21 2019 at 14:25UTC