Stream: t-compiler

Topic: moving compiler to xid-unicode


matklad (Jul 25 2019 at 12:35, on Zulip):

In https://github.com/rust-lang/rust/pull/62848 I propose to move rustc to use unicode-xid crate. Should this be discussed at some t-compiler meeting? Or is it ok to just make sure that t-compiler can publish this crate and move forward without big discussion? :]

simulacrum (Jul 25 2019 at 13:10, on Zulip):

I think it's fine to just move forward (but not on compiler team myself). Ensuring that t-compiler has access of some sort is good.

oli (Jul 25 2019 at 13:17, on Zulip):

You can tag the PR as T-compiler and rfcbot it

nikomatsakis (Jul 25 2019 at 13:34, on Zulip):

@matklad we actually have a policy of sorts around this -- listed here -- it mostly applies, except that this is of course not a crate that the compiler team will take ownership of, right?

nikomatsakis (Jul 25 2019 at 13:34, on Zulip):

actually we've a section on third-party crates specifically

matklad (Jul 25 2019 at 13:35, on Zulip):

I think t-compiler should take ownership (or at least me personally): this crates is used heavily (by syn), so it seems a good idea to make sure that it is maintained

matklad (Jul 25 2019 at 13:38, on Zulip):

see https://github.com/unicode-rs/unicode-xid/pull/12#issuecomment-515037878 for maintainance discussion

matklad (Jul 26 2019 at 15:24, on Zulip):

@oli I can't rfcbot :sob: https://github.com/rust-lang/rust/pull/62848#issuecomment-515075895

simulacrum (Jul 26 2019 at 15:27, on Zulip):

@matklad asked for you

matklad (Sep 03 2019 at 18:35, on Zulip):

ping @nikomatsakis @nagisa, there's some ticky boxes for you at https://github.com/rust-lang/rust/pull/62848

nikomatsakis (Sep 03 2019 at 20:14, on Zulip):

checked

nagisa (Sep 04 2019 at 03:48, on Zulip):

checked as well

Last update: Nov 22 2019 at 04:30UTC