Stream: t-compiler

Topic: ena#19 values_since_snapshot


nikomatsakis (Mar 19 2019 at 14:26, on Zulip):

@varkor -- I left a review on ena#19 -- just had a minor nit. Do you think you'd be able to add some docs? I can certainly publish a new version, as well.

nikomatsakis (Mar 19 2019 at 14:28, on Zulip):

actually, I think I misunderstood

nikomatsakis (Mar 19 2019 at 14:28, on Zulip):

never mind, I'll just land as is

nikomatsakis (Mar 19 2019 at 14:32, on Zulip):

I guess I'll release this as 0.12.0 since it is technically a breaking change

nikomatsakis (Mar 19 2019 at 14:35, on Zulip):

see https://github.com/rust-lang-nursery/ena/pull/20 -- published

varkor (Mar 19 2019 at 15:35, on Zulip):

thanks!

varkor (Mar 19 2019 at 23:20, on Zulip):

I've committed a faux pas... I assumed this change was sufficient for rustc without actually patching it in locally

varkor (Mar 19 2019 at 23:20, on Zulip):

it turns out that we need the method to be more public, and also to add the method to SnapshotVec to account for the type variable data structures

varkor (Mar 19 2019 at 23:21, on Zulip):

I'm about to submit another PR; sorry for the unnecessary version

varkor (Mar 20 2019 at 10:10, on Zulip):

@nikomatsakis: I've submitted https://github.com/rust-lang-nursery/ena/pull/21 – sorry for the trouble

nikomatsakis (Mar 20 2019 at 12:48, on Zulip):

@varkor np :)

nikomatsakis (Mar 22 2019 at 21:19, on Zulip):

@varkor ok, sorry, just reviewed that PR

nikomatsakis (Mar 22 2019 at 21:20, on Zulip):

Merged. Can you maybe open a PR bumping the cargo.toml version number and updating RELEASES.md? I guess it might as well be a new major version again

Charles Lew (Mar 23 2019 at 03:23, on Zulip):

I've opened a PR to bump the version to 0.13.0: https://github.com/rust-lang-nursery/ena/pull/22

It seems ena doesn't have a RELEASES.md (like rustc do)...

Last update: Nov 20 2019 at 02:40UTC