Stream: t-compiler

Topic: #51212 suggestions and extern-prelude


nikomatsakis (Aug 23 2018 at 14:19, on Zulip):

hi @qmx :)

qmx (Aug 23 2018 at 14:20, on Zulip):

yea, I'll look into the make tests and report back

nikomatsakis (Aug 23 2018 at 14:22, on Zulip):

in particular look for the existing test

nikomatsakis (Aug 23 2018 at 14:22, on Zulip):

src/test/run-make-fulldeps/extern-prelude/shadow-prelude.rs

nikomatsakis (Aug 23 2018 at 15:18, on Zulip):

@qmx run-make tests are basically the "just use a dang makefile" kind of test. Lots of power, lots of annoyingness.

qmx (Aug 23 2018 at 15:22, on Zulip):

usually those were the ones that did break on my dockerized builds :P

nikomatsakis (Aug 24 2018 at 21:26, on Zulip):

@qmx ping =)

qmx (Aug 25 2018 at 02:02, on Zulip):

Just saw your comments on the issue

qmx (Aug 25 2018 at 02:03, on Zulip):

The plan is to work on it tomorrow

qmx (Aug 27 2018 at 12:38, on Zulip):

addressed the comments there, will continue trying to make tests work

nikomatsakis (Aug 27 2018 at 12:57, on Zulip):

@qmx how are you trying to make tests work now?

nikomatsakis (Aug 27 2018 at 12:58, on Zulip):

are you going to add a run-make test?

qmx (Aug 27 2018 at 13:15, on Zulip):

yep, that's the one

nikomatsakis (Aug 27 2018 at 13:19, on Zulip):

ok!

nikomatsakis (Aug 27 2018 at 13:19, on Zulip):

I'd love to see that landed, as I'm sure you would too :P

qmx (Aug 27 2018 at 13:21, on Zulip):

yeap, trying really hard to wrap this up in the next 40 mins :P

qmx (Aug 27 2018 at 13:26, on Zulip):

@nikomatsakis do you have a good suggestion for the test? I was thinking on adding something like foo::bar::Baz and referencing it from main, then grepping for the suggestion

nikomatsakis (Aug 27 2018 at 13:26, on Zulip):

yeah I can't really think of anything better

nikomatsakis (Aug 27 2018 at 13:26, on Zulip):

seems good enough for now

qmx (Aug 27 2018 at 14:13, on Zulip):

test pushed

qmx (Aug 27 2018 at 14:32, on Zulip):

@nikomatsakis when you have some time, can you double-check the changes/test are good? I think this is finally done :)

Last update: Nov 22 2019 at 04:55UTC