hi @qmx :)
yea, I'll look into the make tests and report back
in particular look for the existing test
@qmx run-make tests are basically the "just use a dang makefile" kind of test. Lots of power, lots of annoyingness.
usually those were the ones that did break on my dockerized builds :P
@qmx ping =)
Just saw your comments on the issue
The plan is to work on it tomorrow
addressed the comments there, will continue trying to make tests work
@qmx how are you trying to make tests work now?
are you going to add a run-make test?
yep, that's the one
I'd love to see that landed, as I'm sure you would too :P
yeap, trying really hard to wrap this up in the next 40 mins :P
@nikomatsakis do you have a good suggestion for the test? I was thinking on adding something like
foo::bar::Baz and referencing it from main, then grepping for the suggestion
yeah I can't really think of anything better
seems good enough for now
@nikomatsakis when you have some time, can you double-check the changes/test are good? I think this is finally done :)