Stream: t-compiler

Topic: pre-meeting triage 2019-11-28 #54818


pnkfelix (Nov 28 2019 at 12:43, on Zulip):

I will be doing pre-triage in this channel.

pnkfelix (Nov 28 2019 at 12:48, on Zulip):

first up: un-prioritized nominated issues. There are 8.

pnkfelix (Nov 28 2019 at 12:49, on Zulip):

unpri nom 1/8: "thread 'rustc' panicked at 'called Result::unwrap() on an Err value: DistinctSources(DistinctSources" #66805

pnkfelix (Nov 28 2019 at 12:50, on Zulip):

needs mcve. Going with P-high for this one for now (and removing nomination label).

pnkfelix (Nov 28 2019 at 12:50, on Zulip):

unpri nom 2/8: "miri no longer builds after rust-lang/rust#66646" #66795

pnkfelix (Nov 28 2019 at 12:51, on Zulip):

P-medium, removing nomination label.

pnkfelix (Nov 28 2019 at 13:04, on Zulip):

unpri nom 3/8: "Compiler panic while building crate with tokio, rocket, and snafu" #66787

pnkfelix (Nov 28 2019 at 13:05, on Zulip):

P-high, removing nomination label

pnkfelix (Nov 28 2019 at 13:06, on Zulip):

unpri nom 4/8: "Broken MIR ICE" #66768

pnkfelix (Nov 28 2019 at 13:08, on Zulip):

ugh it looks like this is blossoming into a family of normalization related ICEs.

pnkfelix (Nov 28 2019 at 13:08, on Zulip):

P-high, removing nomination label

pnkfelix (Nov 28 2019 at 13:09, on Zulip):

unpri nom 5/8: "Regression in Error conversion from Infallible" #66757

pnkfelix (Nov 28 2019 at 13:11, on Zulip):

reading over the comment thread here, i cannot immediately tell whether I need to rope T-lang into this issue (which is already tagged with T-compiler and T-libs) ...

pnkfelix (Nov 28 2019 at 13:14, on Zulip):

at the very least it seems like we might need to hold off (again) on stabilizing ! ...

pnkfelix (Nov 28 2019 at 13:14, on Zulip):

anyway, P-high. Leaving nominated.

pnkfelix (Nov 28 2019 at 13:15, on Zulip):

unpri nom 6/8: "Closure type error" #66706

pnkfelix (Nov 28 2019 at 13:17, on Zulip):

that's pretty fun

pnkfelix (Nov 28 2019 at 13:18, on Zulip):

triage: P-high, removing nomination. tagging with const-eval.

pnkfelix (Nov 28 2019 at 13:29, on Zulip):

unpri nom 7/8: "rustc crash on 1.39.0 stable with combination of async and .." #66618

pnkfelix (Nov 28 2019 at 13:31, on Zulip):

okay so the task here is high priority but easy: identify which PR on nightly fixed this and consider backporting it.

pnkfelix (Nov 28 2019 at 13:31, on Zulip):

P-high, leaving nominated.

pnkfelix (Nov 28 2019 at 13:34, on Zulip):

well, it really doesn't deserve to stay nominated. I'll just advertise it on the meeting channel.

pnkfelix (Nov 28 2019 at 13:37, on Zulip):

unpri nom 8/8: "under latest MinGW, cannot link with C code using stdout" #47048

pnkfelix (Nov 28 2019 at 13:38, on Zulip):

okay we started discussing what priority to give this last week, but then I switched topics to the WG-traits checkin

pnkfelix (Nov 28 2019 at 13:38, on Zulip):

(archive here)

pnkfelix (Nov 28 2019 at 13:38, on Zulip):

leaving nominated. maybe we can assign a priority today.

pnkfelix (Nov 28 2019 at 13:39, on Zulip):

though perhaps I should write a comment with niko's summary. I'll do that now.

pnkfelix (Nov 28 2019 at 13:44, on Zulip):

okay. I wrote a summary. And now I think I'll mark this P-high but remove nomination.

pnkfelix (Nov 28 2019 at 13:51, on Zulip):

there are zero un-prioritized beta regressions

pnkfelix (Nov 28 2019 at 13:51, on Zulip):

there is one un-prioritized nightly regression

pnkfelix (Nov 28 2019 at 13:52, on Zulip):

unpri ν regr 1/1: "Broken MIR after compiler update when indexing statics with async values" #66695

pnkfelix (Nov 28 2019 at 13:52, on Zulip):

has PR. Marking P-high.

pnkfelix (Nov 28 2019 at 13:59, on Zulip):

next, a pass over the nominated issues to make sure there's no stale artifacts from last week.

pnkfelix (Nov 28 2019 at 14:01, on Zulip):

removing nomination tag from "sysroot spans are not printed on some targets (affected: Debian, rust-lang's own i586; unaffected: Fedora)" #53081, which we discussed last week.

pnkfelix (Nov 28 2019 at 14:05, on Zulip):

we discussed "NLL Regressions in 1.40" #66517 last week. I'm going to self-assign it to try to push through the follow up work asynchronously.

pnkfelix (Nov 28 2019 at 14:08, on Zulip):

ah, wait, we had agreed "I'm fine with tabling and coming back to it next week with a todo list" for #66517

pnkfelix (Nov 28 2019 at 14:09, on Zulip):

(see also discussion in parallel wg-nll zulip topic )

pnkfelix (Nov 28 2019 at 14:11, on Zulip):

Okay that covers all the issues that we looked at last week, I think.

pnkfelix (Nov 28 2019 at 14:11, on Zulip):

(at least ones where I would feel comfortable removing the I-nominated tag)

pnkfelix (Nov 28 2019 at 14:15, on Zulip):

looking over the P-high issues now, mainly to try to identify issues that we could downgrade to P-medium or close.

pnkfelix (Nov 28 2019 at 14:16, on Zulip):

@centril regarding " improper_ctypes fires for &mut T, &T, *const T and *mut T (when T: Sized)" #66220, can I remove the I-nominated tag there? Or is that something you think still needs (more) discussion in T-lang meeting?

pnkfelix (Nov 28 2019 at 14:27, on Zulip):

downgrading "The compiler should report publicly exported type names if possible" #21934 to P-medium. It got attention, that was good, but that doesn't mean it should stay P-high.

pnkfelix (Nov 28 2019 at 14:30, on Zulip):

looking at "Miscompilation with target-cpu=znver1 (AMD Ryzen 1000/2000 series) on Windows + LLVM 9." #63959; tempted to downgrade to P-medium (as "just an LLVM bug"). Posted question on parallel zulip topic.

pnkfelix (Nov 28 2019 at 14:38, on Zulip):

okay, I think now I'll start preparing a hackmd agena for today.

Last update: Dec 12 2019 at 00:55UTC