I'm inclined to r+ https://github.com/rust-lang/rust/pull/62593 -- anybody have strong opinions? It moves abi related tests from
src/test/run-pass/abi. In some cases, also from directiories like
src/test/run-pass/abi/struct. I'm not sure what the ideal org is but it seems like an improvement. @centril, you may care about this...
@nikomatsakis agree that it is better organization... but something weird is going on; it seems to be moving tests in the run-pass directory... but we removed it?
(i.e. why is there not a merge conflict... will investigate)
(oh no, we have a test in https://github.com/rust-lang/rust/blob/master/src/test/run-pass/generator/niche-in-generator.rs that isn't being tested)
(see https://github.com/rust-lang/rust/tree/master/src/test/run-pass -- there's just a single test ^--- there)
cc @Vadim Petrochenkov ^---
It seems to always happen when test suites are removed.
@Vadim Petrochenkov any idea why the PR doesn't have a merge conflict tho?
(I'll go move the generator test)
Vadim Petrochenkov any idea why the PR doesn't have a merge conflict tho?
git is file-based, not dir-based
so it doesnt care if you removed the dir
and there's no conflict on the file level
@RalfJ oh, but so what happens if we merge the PR? does it get moved back to run-pass?
git follows renames of files, but not of dirs -- it doesnt even have that concept
wait, what is "it"?
that old generator thing was likely a PR adding a new test getting rebased against the test suite rename
new file being created in a renamed dir, git doesnt even notice anything weird is going on
@RalfJ https://github.com/rust-lang/rust/pull/62593 reorganizes files in the
run-pass dir, but that dir does not exist anymore (well... it does... but those files don't)
git could be "smart" enough that if one PR renames A to B, and then another one renames A to C, when the former gets rebased it results in a B -> C rename
but I haven't tried. but that seems consistent with following renames.
(the github UI shows
src/test/run-pass/abi-sysv64-arg-passing.rs → src/test/run-pass/abi/abi-sysv64-arg-passing.rs tho)
(I recently rebased something over some rename and was super-happy that that just worked. would have been extremely painful.)
(the github UI shows
src/test/run-pass/abi-sysv64-arg-passing.rs → src/test/run-pass/abi/abi-sysv64-arg-passing.rstho)
GH doesnt re-render when the target gets updated
author needs to rebase and force-push for an updated diff
I'll note that as a comment then
good catch @centril <3