Stream: t-compiler

Topic: #53668 if-let-chain edition changes


davidtwco (Aug 31 2018 at 13:52, on Zulip):

@nikomatsakis Is this the type of warning that you'd expect?

warning: ambigious use of `&&`
  --> src/test/ui/rfc-2497-if-let-chains/syntax-ambiguity-2015.rs:22:47
   |
22 |     if let Range { start: _, end: _ } = true..true && false { }
   |                                               ^^^^^^^^^^^^^ help: consider adding parenthesis: `(true && false)`
   |
   = note: This will be a error in Rust 2018 until the `let_chains` feature is stabilised.
Jake Goulding (Aug 31 2018 at 14:01, on Zulip):

stabilised

Someone let British English into the compiler.

davidtwco (Aug 31 2018 at 14:15, on Zulip):

Submitted #53854 with that changed to Freedom English. The approach I've taken is a little naive and probably doesn't cover some cases, but it's a start.

nikomatsakis (Aug 31 2018 at 14:19, on Zulip):

@davidtwco I'll take a look. Not sure if you saw my comment, but we discussed this in the lang team meeting yesterday and we were thinking we could make this an unconditional error

nikomatsakis (Aug 31 2018 at 14:19, on Zulip):

at least try :)

davidtwco (Aug 31 2018 at 14:28, on Zulip):

I saw it just as I was submitting the PR. I can change it to that easily enough.

nikomatsakis (Aug 31 2018 at 18:02, on Zulip):

left a review @davidtwco

nikomatsakis (Aug 31 2018 at 18:02, on Zulip):

tl;dr let's make it a hard error :)

davidtwco (Aug 31 2018 at 18:35, on Zulip):

@nikomatsakis Fixed.

davidtwco (Aug 31 2018 at 18:38, on Zulip):

In fact, need to update one of the messages.

davidtwco (Aug 31 2018 at 18:43, on Zulip):

Alright, now it's fixed.

Last update: Nov 20 2019 at 01:10UTC