Stream: t-compiler

Topic: Old `quote` patch


nnethercote (Oct 09 2019 at 21:26, on Zulip):

@Alex Crichton Ages ago you gave me this patch for quote, and it gave some speedups: https://paste.mozilla.org/nyLL8KiZ

nnethercote (Oct 09 2019 at 21:27, on Zulip):

There was some issue with it using a Rust feature that was newish, so dtolnay didn't want to include it until later

nnethercote (Oct 09 2019 at 21:27, on Zulip):

I just tried updating my repo with that patch applied and got conflicts. Anyway, I'm wondering if it's still relevant?

nnethercote (Oct 09 2019 at 21:29, on Zulip):

https://github.com/alexcrichton/proc-macro2/pull/94#issuecomment-392649679 is relevant

nnethercote (Oct 09 2019 at 21:30, on Zulip):

Oh, https://github.com/dtolnay/quote/pull/91 was filed and then closed

nnethercote (Oct 09 2019 at 21:30, on Zulip):

/me will try that code out

Alex Crichton (Oct 09 2019 at 22:03, on Zulip):

@nnethercote oh lord the macros are way more complicated than I remember now

Alex Crichton (Oct 09 2019 at 22:03, on Zulip):

I dunno if that optimization is in there nowadays

Alex Crichton (Oct 09 2019 at 22:03, on Zulip):

I'd ping @dtolnay to learn for sure

Last update: Nov 16 2019 at 01:05UTC