Stream: t-compiler

Topic: pre-meeting triage 2019-06-27 #54818


pnkfelix (Jun 27 2019 at 13:22, on Zulip):

I'll be doing pre-triage in this channel.

pnkfelix (Jun 27 2019 at 13:23, on Zulip):

(yep, I'm super late starting today; been working on an NLL blog post that needs to go up before the release...)

pnkfelix (Jun 27 2019 at 13:23, on Zulip):

we have 11 unprioritizied nominated T-compiler issues

pnkfelix (Jun 27 2019 at 13:24, on Zulip):

first up for priority assignment: "Incremental compilation results in linker error when method use is removed" #59535

oli (Jun 27 2019 at 13:24, on Zulip):

I'll start the list from the end and we can meet in the middle

pnkfelix (Jun 27 2019 at 13:25, on Zulip):

@oli thanks

pnkfelix (Jun 27 2019 at 13:25, on Zulip):

I'm going to call #59535 P-high for now

pnkfelix (Jun 27 2019 at 13:26, on Zulip):

(some incremental compilation bugs get P-medium assignment, but given that this ends up causing a link-time error rather than say an ICE scares the heck out of me)

oli (Jun 27 2019 at 13:26, on Zulip):

Nightly Rust hangs forever with a simple 2-line dotenv_codegen and println! #62167

centril (Jun 27 2019 at 13:27, on Zulip):

I'm gonna remove t-compiler from https://github.com/rust-lang/rust/issues/61553

pnkfelix (Jun 27 2019 at 13:27, on Zulip):

(oh and I'm going to leave #59535 nominated)

oli (Jun 27 2019 at 13:28, on Zulip):

I'm not sure #62167 is a compiler problem, I'd say it's a proc macro with an infinite loop (or very long running compilation). Unnominating and pinging dotenv devs

pnkfelix (Jun 27 2019 at 13:28, on Zulip):

next for P assignment: "ICE: stack overflow using imported type in Fn/FnMut across three crates" #61711

pnkfelix (Jun 27 2019 at 13:30, on Zulip):

#61711 sounds goofy. Three crates, c -> b -> a, and something about trying to define fn f<F: Fn(b::a::Struct)>(_: F) { }

pnkfelix (Jun 27 2019 at 13:30, on Zulip):

going to call #61711 P-high. But removing nomination tag; it sounds hopefully obscure enough that we don't have to discuss it today

pnkfelix (Jun 27 2019 at 13:31, on Zulip):

I will assign #61711 to self for initial investigation though.

pnkfelix (Jun 27 2019 at 13:32, on Zulip):

next for P assignment: "Regression: implementing Clone for trait objects" #61759

pnkfelix (Jun 27 2019 at 13:32, on Zulip):

hmm another infinite recursion stack overflow

pnkfelix (Jun 27 2019 at 13:33, on Zulip):

current theory is that #61759 was injected by #59500

centril (Jun 27 2019 at 13:33, on Zulip):

(if true ==> close the issue with "we are very sorry")

pnkfelix (Jun 27 2019 at 13:33, on Zulip):

(needs bisection to verify that, though)

centril (Jun 27 2019 at 13:34, on Zulip):

So P-high for bisection?

pnkfelix (Jun 27 2019 at 13:34, on Zulip):

yeah: #61759 will be P-high. And i'll unnominate and assign to self.

oli (Jun 27 2019 at 13:35, on Zulip):

Running cargo test with proc macro that uses main fails #62127

oli (Jun 27 2019 at 13:35, on Zulip):

is already marked as a regression and @Vadim Petrochenkov has been pinged, likely will go into beta

pnkfelix (Jun 27 2019 at 13:36, on Zulip):

next for P assignment: " Using extra lifetime parameter when implementing a trait is allowed" #61888

centril (Jun 27 2019 at 13:36, on Zulip):

@oli should we assign p-high to it tho?

oli (Jun 27 2019 at 13:36, on Zulip):

@centril in my book regression > p-high

pnkfelix (Jun 27 2019 at 13:36, on Zulip):

I'm going to remove T-compiler from #61888 ; i believe at this point it is nominatd for lang team discussion

oli (Jun 27 2019 at 13:36, on Zulip):

but sure

centril (Jun 27 2019 at 13:37, on Zulip):

@oli add to the list of "our labeling system is confusing" ;)

pnkfelix (Jun 27 2019 at 13:37, on Zulip):

centril in my book regression > p-high

(some regressions are deliberately tagged as eg. P-medium; so best to be explicit and P-high if it is important, for now at least.)

centril (Jun 27 2019 at 13:38, on Zulip):

Added P-high to it

pnkfelix (Jun 27 2019 at 13:38, on Zulip):

next for P assignment: "Built-in derive macros Encodable, Decodable, RustcEncodable and RustcDecodable are stable" #62048

centril (Jun 27 2019 at 13:38, on Zulip):

Petrochenkov is on top of it; P-medium?

pnkfelix (Jun 27 2019 at 13:39, on Zulip):

yeah seems like a long-standing, low risk bug to me

pnkfelix (Jun 27 2019 at 13:39, on Zulip):

I'll ask on the issue #62048 if petrochenkov wants to be assigned to it.

pnkfelix (Jun 27 2019 at 13:40, on Zulip):

next for P assignment: "Rustdoc recursion limit issue" #62059

oli (Jun 27 2019 at 13:41, on Zulip):

ICE with borrow checker in nightly #62107

pnkfelix (Jun 27 2019 at 13:41, on Zulip):

for #62059, it sounds like we and/or rustdoc really needs to figure out what to do here

pnkfelix (Jun 27 2019 at 13:42, on Zulip):

#62059: P-high. Leaving nominated and unassigned.

oli (Jun 27 2019 at 13:42, on Zulip):

regression from stable/beta to nightly, an error is now an ICE, marked as regression + P-high since there's no error message and just the ICE

pnkfelix (Jun 27 2019 at 13:43, on Zulip):

last from P assignment from top-down: "miri no longer builds after rust-lang/rust#62081" #62101

oli (Jun 27 2019 at 13:43, on Zulip):

heh

pnkfelix (Jun 27 2019 at 13:43, on Zulip):

oh

oli (Jun 27 2019 at 13:43, on Zulip):

already unnominated

pnkfelix (Jun 27 2019 at 13:43, on Zulip):

never mind

oli (Jun 27 2019 at 13:43, on Zulip):

there's a PR waiting on bors

oli (Jun 27 2019 at 13:44, on Zulip):

I think I'm doing something wrong. I'm taking too much time on each issue

pnkfelix (Jun 27 2019 at 13:44, on Zulip):

okay, there aren't any nominations with no team assigned

pnkfelix (Jun 27 2019 at 13:45, on Zulip):

I think I'm doing something wrong. I'm taking too much time on each issue

Well, I think its more panic that drives me

centril (Jun 27 2019 at 13:45, on Zulip):

@pnkfelix do you want to be assigned to https://github.com/rust-lang/rust/issues/62107 ?

pnkfelix (Jun 27 2019 at 13:45, on Zulip):

yeah I'll take #62107

centril (Jun 27 2019 at 13:45, on Zulip):

or maybe @Matthew Jasper

pnkfelix (Jun 27 2019 at 13:45, on Zulip):

I can (and should) look into delegating

pnkfelix (Jun 27 2019 at 13:46, on Zulip):

there are no beta-regressions w/o P-label

pnkfelix (Jun 27 2019 at 13:46, on Zulip):

nor are there any nightly-regressions w/o P-label ((in both cases, I think it is filtered so we do not see bugs attached to other teams)

pnkfelix (Jun 27 2019 at 13:47, on Zulip):

we do now have 38 P-high T-compiler issues

centril (Jun 27 2019 at 13:47, on Zulip):

jesus

pnkfelix (Jun 27 2019 at 13:48, on Zulip):

16 of which are unassigned

pnkfelix (Jun 27 2019 at 13:49, on Zulip):

and of those, 9 are not already nominated for discussion at the meeting itself

pnkfelix (Jun 27 2019 at 13:50, on Zulip):

so maybe lets spend the remaining 11 minutes seeing if we can assign these bugs

pnkfelix (Jun 27 2019 at 13:50, on Zulip):

I can and should take "Forgone caching in cycles caused much overflow in trait solving" #61960

centril (Jun 27 2019 at 13:50, on Zulip):

https://github.com/rust-lang/rust/issues/61696 ==> @eddyb ?

pnkfelix (Jun 27 2019 at 13:50, on Zulip):

(its largely a metabug about me trying to gather information about how good or not good our fix was)

eddyb (Jun 27 2019 at 13:51, on Zulip):

oh yeah I should go fix that now that we know how

pnkfelix (Jun 27 2019 at 13:51, on Zulip):

okay lets give that to @eddyb then

centril (Jun 27 2019 at 13:52, on Zulip):

(Why is https://github.com/rust-lang/rust/issues/56132 P-high?)

pnkfelix (Jun 27 2019 at 13:52, on Zulip):

because estebank went and marked a bunch of issues P-high

davidtwco (Jun 27 2019 at 13:52, on Zulip):

I was about to ask if anyone knew if that was still being worked on.

davidtwco (Jun 27 2019 at 13:54, on Zulip):

I'd be happy to try tackle #61963 too.

pnkfelix (Jun 27 2019 at 13:54, on Zulip):

@davidtwco sure; can you assign yourself?

centril (Jun 27 2019 at 13:55, on Zulip):

assigned @davidtwco

pnkfelix (Jun 27 2019 at 13:56, on Zulip):

I'll assign #59494 to myself.

pnkfelix (Jun 27 2019 at 13:56, on Zulip):

and I will assign #60070 to myself

pnkfelix (Jun 27 2019 at 13:57, on Zulip):

regarding " Compiler panic at Box<Any>" #60363 , @oli had posted a comment in May that seemed to explain things to some extent

pnkfelix (Jun 27 2019 at 13:59, on Zulip):

well I'll at least assign "ICE with unsized associated type" #60431 to myself as well

pnkfelix (Jun 27 2019 at 13:59, on Zulip):

there are still five issues that are P-high, unassigned, and not nominated

centril (Jun 27 2019 at 13:59, on Zulip):

@pnkfelix are you assigning too much to yourself? where are all the compiler team contributors?

pnkfelix (Jun 27 2019 at 14:00, on Zulip):

this is indeed a problem

eddyb (Jun 27 2019 at 14:00, on Zulip):

something something summer-time

pnkfelix (Jun 27 2019 at 14:00, on Zulip):

and one I hope we discuss tomorrow

Last update: Nov 16 2019 at 01:05UTC