Stream: t-compiler

Topic: `unwrap_usize` should at least try #59369


nikomatsakis (Jul 12 2019 at 10:41, on Zulip):

Ugh @oli how did we not land this PR yet. (I'm going through review queue)

nikomatsakis (Jul 12 2019 at 10:42, on Zulip):

I remember we looked at it together...

eddyb (Jul 12 2019 at 10:45, on Zulip):

should I try to look at it again today and see if there's anything that I could help with?

nikomatsakis (Jul 12 2019 at 10:46, on Zulip):

my memory is that the PR itself was fairly harmless but that we needed (separately) to do a review of how normalization/canonicalization played into constants

nikomatsakis (Jul 12 2019 at 10:46, on Zulip):

I'm lokoing over again to try and jog my memory

eddyb (Jul 12 2019 at 10:48, on Zulip):

ah I see

eddyb (Jul 12 2019 at 10:48, on Zulip):

I had left some comments that oli didn't resolve

eddyb (Jul 12 2019 at 10:48, on Zulip):

like this https://github.com/rust-lang/rust/pull/59369/files#r285040505

eddyb (Jul 12 2019 at 10:49, on Zulip):

we need to fail gracefully everywhere, we can't ICE in any of this

eddyb (Jul 12 2019 at 10:50, on Zulip):

(well, we can ICE in codegen, I guess. but not in inference)

eddyb (Jul 12 2019 at 10:50, on Zulip):

@nikomatsakis should I wait for @oli or try to rebase the PR myself and make the changes I suggested?

nikomatsakis (Jul 12 2019 at 10:53, on Zulip):

I don't know. I'm having trouble remembering the details of this now.

nikomatsakis (Jul 12 2019 at 10:53, on Zulip):

@eddyb hmm I wonder if it makes sense to try and do an impromptu discussion this morning (perhaps in ~3 hours?) to talk about the overall strategy around normalization, constants, etc?

eddyb (Jul 12 2019 at 10:53, on Zulip):

sure

oli (Jul 12 2019 at 15:55, on Zulip):

Failing to lift would intern?

oli (Jul 12 2019 at 15:56, on Zulip):

Or we should never lift something that isn't already interned?

eddyb (Jul 13 2019 at 13:10, on Zulip):

lift_to_global doesn't even exist anymore, now you have to check it some other way. but it was about inference variables, all along

eddyb (Jul 13 2019 at 13:11, on Zulip):

if you have infer vars, you can't pass them to a query (we should maybe enforce this in the query engine, if we can do it cheaply, idk)

Last update: Nov 20 2019 at 01:55UTC