Stream: t-compiler

Topic: proposal: add source file hashes to debuginfo #69718


eddyb (Apr 05 2020 at 16:01, on Zulip):

@Arlo Siemsen that fix was really prompt, thanks a lot!

eddyb (Apr 05 2020 at 16:02, on Zulip):

this just shows we should perf-test more PRs, perhaps after making the perf testing server more capable (or starting to distribute it across 2-3 servers)

eddyb (Apr 05 2020 at 16:03, on Zulip):

@Arlo Siemsen I posted 3 comparisons here which show the fix, the overall effect and the PRs landed in between the original PR and the fix (the latter two both seem negligible) https://github.com/rust-lang/rust/issues/70785#issuecomment-609438109

eddyb (Apr 05 2020 at 16:05, on Zulip):

@Arlo Siemsen if you want to help test the SHA1 performance compared to MD5, you could make a PR that changes the default (which we'd not actually land) and we could test that. the perf stuff is all on linux but if we make linux do SHA1 hashing it should be indicative of what is now happening on windows

pnkfelix (Apr 20 2020 at 19:41, on Zulip):

/msg @eddyb what was the original topic for "proposal: add source file hashes to debuginfo #69718"? Your statement that "move previous and following... " doesn't move other people's message does not match my own recollection of what I'd observed myself...

pnkfelix (Apr 20 2020 at 19:41, on Zulip):

argh /msg is not a thing in zulip; that seems like something they could fix...

eddyb (Apr 20 2020 at 19:42, on Zulip):

@pnkfelix "cryptographic" in lieu of "source file"

eddyb (Apr 20 2020 at 19:43, on Zulip):

https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/proposal.3A.20add.20cryptographic.20hashes.20to.20debuginfo.20.2369718/near/191131256

pnkfelix (Apr 20 2020 at 19:48, on Zulip):

Okay well I think I was able to revise other peoples' titles

pnkfelix (Apr 20 2020 at 19:48, on Zulip):

but that might because I have admin privileges perhaps?

eddyb (Apr 20 2020 at 20:33, on Zulip):

the weird thing is that the option shows up for me too, except... oh right it's that timed thing

eddyb (Apr 20 2020 at 20:34, on Zulip):

so maybe because I can't edit topics on other people's messages after a while, the before+after feature is also affected

eddyb (Apr 20 2020 at 20:34, on Zulip):

whereas the usual "move this message and all after" does affect all messages

pnkfelix (Apr 20 2020 at 20:46, on Zulip):

but if its a timing thing, then why let me do it as an admin right now?

pnkfelix (Apr 20 2020 at 20:46, on Zulip):

(because I just did move all the messages over into this very topic...)

simulacrum (Apr 20 2020 at 20:52, on Zulip):

everyone should be able to do it

simulacrum (Apr 20 2020 at 20:52, on Zulip):

you may need to start on your own message? not sure

Last update: Jun 04 2020 at 17:15UTC