Stream: t-compiler/wg-nll

Topic: weekly meeting October 9


pnkfelix (Oct 09 2018 at 19:27, on Zulip):

hey @WG-compiler-nll just a heads up that our weekly meeting will be starting here in about 3 minutes

pnkfelix (Oct 09 2018 at 19:28, on Zulip):

as usual we will write notes on the NLL Triage Paper

pnkfelix (Oct 09 2018 at 19:30, on Zulip):

everyone may want to skim over the list for the RC2 Milestone and make sure that everything assigned to them 1. makes sense to them and 2. is something they think they will address in two weeks (!)

pnkfelix (Oct 09 2018 at 19:30, on Zulip):

okay let's rock :rock_on:

nikomatsakis (Oct 09 2018 at 19:31, on Zulip):

my sense is that the list is way too long

nikomatsakis (Oct 09 2018 at 19:31, on Zulip):

and that the time may have come to triage it down a bit to "true blockers"?

nikomatsakis (Oct 09 2018 at 19:31, on Zulip):

(and push the rest to Release or something?)

nikomatsakis (Oct 09 2018 at 19:31, on Zulip):

or maybe that is easy, is it just the non-diagnostic things?

pnkfelix (Oct 09 2018 at 19:31, on Zulip):

so maybe we should look at the NLL-sound vs NLL-complete vs NLL-diagnostics lists separately?

pnkfelix (Oct 09 2018 at 19:33, on Zulip):

NLL sound has 10 open issues

pnkfelix (Oct 09 2018 at 19:33, on Zulip):

most are assigned to either @nikomatsakis or myself

pnkfelix (Oct 09 2018 at 19:33, on Zulip):

the exceptions being: #54692, assigned to mikhail-m1

pnkfelix (Oct 09 2018 at 19:34, on Zulip):

#54620, assigned to matthewjasper

davidtwco (Oct 09 2018 at 19:34, on Zulip):

The only NLL issue I’ve got assigned is a minor diagnostic one from the diagnostic review so if there are any higher priority issues that need handled I have time.

pnkfelix (Oct 09 2018 at 19:34, on Zulip):

and #54332, assigned to KiChjang

nikomatsakis (Oct 09 2018 at 19:34, on Zulip):

(@Keith Yeung, do you still have the commit(s) for as that you had pushed to the branch in https://github.com/rust-lang/rust/issues/54332 ? I'd like to try them again)

pnkfelix (Oct 09 2018 at 19:34, on Zulip):

personally I think the NLL-sound issues have to take priority

pnkfelix (Oct 09 2018 at 19:35, on Zulip):

due to my usual argument that the migration system will handle NLL-complete for the short term

pnkfelix (Oct 09 2018 at 19:35, on Zulip):

(and diagnostics ... well, don't our diagnostics already rock compared to AST-borrowck now?)

nikomatsakis (Oct 09 2018 at 19:36, on Zulip):

I think they are by and large an improvement

pnkfelix (Oct 09 2018 at 19:36, on Zulip):

does anyone know if @mikhail-m1 has been active lately? Should we work-steal #54692 ?

Matthew Jasper (Oct 09 2018 at 19:36, on Zulip):

Most of the cases we give bad errors, AST borrowck also gives bad errors.

nikomatsakis (Oct 09 2018 at 19:36, on Zulip):

So regarding the NLL-sound issues assigned to myself, I think I can finish them, I'd be happy to work with @davidtwco or others on them too, but for the most part I have to do some "exploration" to figure out how to fix them, so it's hard for me to mentor per se

davidtwco (Oct 09 2018 at 19:36, on Zulip):

The majority of the last review is resolved and there have been improvements outside that so I expect diagnostics are probably fine.

nikomatsakis (Oct 09 2018 at 19:36, on Zulip):

does anyone know if @mikhail-m1 has been active lately? Should we work-steal #54692 ?

I was wondering the same thing, not sure

Keith Yeung (Oct 09 2018 at 19:36, on Zulip):

@nikomatsakis I do, it's in my fork's branch

nikomatsakis (Oct 09 2018 at 19:36, on Zulip):

I'm kind of keen to see it fixed for unrelated reasons

Keith Yeung (Oct 09 2018 at 19:37, on Zulip):

Aptly named as issue-54332

nikomatsakis (Oct 09 2018 at 19:37, on Zulip):

@Keith Yeung ok, maybe rebase and open a PR with it?

Keith Yeung (Oct 09 2018 at 19:37, on Zulip):

Let me just do that

pnkfelix (Oct 09 2018 at 19:37, on Zulip):

I think I'm going to have my own NLL-sound issues under control this week

pnkfelix (Oct 09 2018 at 19:38, on Zulip):

so maybe I will assign myself to #54692 as well..

nikomatsakis (Oct 09 2018 at 19:38, on Zulip):

I think that one is relatively straight-forward

nikomatsakis (Oct 09 2018 at 19:38, on Zulip):

just requires editing various spots

pnkfelix (Oct 09 2018 at 19:38, on Zulip):

@Matthew Jasper , how are you feeling about #54620 ?

pnkfelix (Oct 09 2018 at 19:38, on Zulip):

i see, you only recently work-stole that yourself

nikomatsakis (Oct 09 2018 at 19:39, on Zulip):

I think they said they are close to a PR on that

nikomatsakis (Oct 09 2018 at 19:39, on Zulip):

earlier today

pnkfelix (Oct 09 2018 at 19:39, on Zulip):

okay

pnkfelix (Oct 09 2018 at 19:40, on Zulip):

so I guess the big question is whether anyone (including me) should try to take more of the load off of @nikomatsakis 's shoulders

nikomatsakis (Oct 09 2018 at 19:40, on Zulip):

I'm not carrying that much

Keith Yeung (Oct 09 2018 at 19:40, on Zulip):

@nikomatsakis https://github.com/rust-lang/rust/pull/54938

nikomatsakis (Oct 09 2018 at 19:40, on Zulip):

that said

nikomatsakis (Oct 09 2018 at 19:41, on Zulip):

I guess https://github.com/rust-lang/rust/issues/54571 might be the more offloadable? I'm not sure yet if it's easy or hard

nikomatsakis (Oct 09 2018 at 19:41, on Zulip):

https://github.com/rust-lang/rust/issues/54105 is probably not that hard, actually

nikomatsakis (Oct 09 2018 at 19:41, on Zulip):

(in that particular case, I kind of know what is to be done and could leave a few notes about it)

Matthew Jasper (Oct 09 2018 at 19:42, on Zulip):

@pnkfelix I'll need to talk to @nikomatsakis about something, but the test case in that issue should be solved soon.

nikomatsakis (Oct 09 2018 at 19:42, on Zulip):

so I guess if someone wants to do a bit of exploration, #54571 might be a good one to investigate

nikomatsakis (Oct 09 2018 at 19:42, on Zulip):

I plan to be working on the other for the rest of the day, so I'd be happy to chat about it...

pnkfelix (Oct 09 2018 at 19:43, on Zulip):

I just realized

pnkfelix (Oct 09 2018 at 19:43, on Zulip):

we didn't actually look at the other part of this

pnkfelix (Oct 09 2018 at 19:43, on Zulip):

which is: Can any of the NLL-sound items be dropped from RC2

pnkfelix (Oct 09 2018 at 19:44, on Zulip):

we've lived with compiler bugs before

pnkfelix (Oct 09 2018 at 19:44, on Zulip):

i haven't really looked properly at #54124 yet

pnkfelix (Oct 09 2018 at 19:45, on Zulip):

I'm pretty sure I can squash the ICE though

nikomatsakis (Oct 09 2018 at 19:45, on Zulip):

that one doesn't seem vital though, I agree

Santiago Pastorino (Oct 09 2018 at 19:45, on Zulip):

I also don’t have anything assigned

pnkfelix (Oct 09 2018 at 19:46, on Zulip):

oh, also: @nikomatsakis , what milestone should we assign to #54779 ?

Santiago Pastorino (Oct 09 2018 at 19:46, on Zulip):

besides https://github.com/rust-lang/rust/issues/21232

Santiago Pastorino (Oct 09 2018 at 19:46, on Zulip):

so if there’s something more important let me know

nikomatsakis (Oct 09 2018 at 19:46, on Zulip):

oh, also: @nikomatsakis , what milestone should we assign to #54779 ?

I don't consider that a blocker

pnkfelix (Oct 09 2018 at 19:47, on Zulip):

besides https://github.com/rust-lang/rust/issues/21232

and I'm under the impression that the PR you (@Santiago Pastorino) just put up will address that?

nikomatsakis (Oct 09 2018 at 19:47, on Zulip):

well, it makes it a hard error to do a.b.c = x with an uninitialized a

pnkfelix (Oct 09 2018 at 19:47, on Zulip):

right.

nikomatsakis (Oct 09 2018 at 19:47, on Zulip):

OK.

pnkfelix (Oct 09 2018 at 19:47, on Zulip):

I really need to fork off separate issues

nikomatsakis (Oct 09 2018 at 19:47, on Zulip):

it addresses it "sufficiently for now", in other words

pnkfelix (Oct 09 2018 at 19:47, on Zulip):

its become untenable for discussions

Santiago Pastorino (Oct 09 2018 at 19:47, on Zulip):

should I tackle that one now?

pnkfelix (Oct 09 2018 at 19:48, on Zulip):

(deleted)

Santiago Pastorino (Oct 09 2018 at 19:48, on Zulip):

I’d like to do so but prefer to do something that is a priority

pnkfelix (Oct 09 2018 at 19:49, on Zulip):

@Santiago Pastorino yes, if i understand correctly, the work you've done should already cover everything that I want for #21232 for now

pnkfelix (Oct 09 2018 at 19:49, on Zulip):

so lets find something else for you to do. :)

nikomatsakis (Oct 09 2018 at 19:50, on Zulip):

ok so either of the following:

would be candidates for @Santiago Pastorino and @davidtwco (both of whom I think were looking for things :)

nikomatsakis (Oct 09 2018 at 19:50, on Zulip):

the former I can explain in more detail what to do, the latter is a bit more 'exploration needed'

pnkfelix (Oct 09 2018 at 19:50, on Zulip):

and also #54692

nikomatsakis (Oct 09 2018 at 19:50, on Zulip):

but the former is very obscure

pnkfelix (Oct 09 2018 at 19:51, on Zulip):

(I work-stole #54692 but only to make sure it was assigned to a second person)

pnkfelix (Oct 09 2018 at 19:51, on Zulip):

@nikomatsakis if I'm gointg to steal something, maybe I should take #54105

pnkfelix (Oct 09 2018 at 19:52, on Zulip):

given that I've already somewhat familiar with the variance system

nikomatsakis (Oct 09 2018 at 19:53, on Zulip):

that seems reasonable, yes

pnkfelix (Oct 09 2018 at 19:54, on Zulip):

@Santiago Pastorino okay: I'm going to put you on #54692

nikomatsakis (Oct 09 2018 at 19:54, on Zulip):

+1

nikomatsakis (Oct 09 2018 at 19:54, on Zulip):

though I have some mild concern that @mikhail-m1 may be actively hacking on it, hard to tell

Santiago Pastorino (Oct 09 2018 at 19:55, on Zulip):

:+1:

pnkfelix (Oct 09 2018 at 19:55, on Zulip):

well lets hope @mikhail-m1 sees the comments on the issue (or in zulip), and can chime in on whether they are active on it or not

nikomatsakis (Oct 09 2018 at 19:55, on Zulip):

k

pnkfelix (Oct 09 2018 at 19:56, on Zulip):

Okay

mikhail-m1 (Oct 09 2018 at 19:56, on Zulip):

I working on it, sorry don't know how to quote in Mobile app: anyone know if @mikhail-m1 has been active lately? Should we work-steal #54692 ?

pnkfelix (Oct 09 2018 at 19:57, on Zulip):

ah okay!

pnkfelix (Oct 09 2018 at 19:57, on Zulip):

@Santiago Pastorino : maybe you can check in with @mikhail-m1

pnkfelix (Oct 09 2018 at 19:58, on Zulip):

either after the meeting or at some other point in the near future

pnkfelix (Oct 09 2018 at 19:58, on Zulip):

to try to determine whether your assistance there would be of use

nikomatsakis (Oct 09 2018 at 19:59, on Zulip):

@pnkfelix https://github.com/rust-lang/rust/issues/54124 might also be a good one to offload for you

nikomatsakis (Oct 09 2018 at 19:59, on Zulip):

if someone is looking for things to work steal

pnkfelix (Oct 09 2018 at 19:59, on Zulip):

(but its possible that the best thing would be to have @Santiago Pastorino take yet another issue.)

pnkfelix (Oct 09 2018 at 19:59, on Zulip):

true

pnkfelix (Oct 09 2018 at 19:59, on Zulip):

very true

pnkfelix (Oct 09 2018 at 20:00, on Zulip):

@Santiago Pastorino I'm going to unassign you from #54692 and assign you to #54124

nikomatsakis (Oct 09 2018 at 20:01, on Zulip):

ok, I'm going to go poke at the damn issues assigned to me

/me hasn't had any time to code today, really

Santiago Pastorino (Oct 09 2018 at 20:02, on Zulip):

:+1:

pnkfelix (Oct 09 2018 at 20:03, on Zulip):

so the only other thing I wanted to mention: I did look briefly at NLL-complete, and in short, it seems fine

pnkfelix (Oct 09 2018 at 20:03, on Zulip):

(the main items we care about should be handled in the near future, assuming I start the review for #54528 tout suite)

pnkfelix (Oct 09 2018 at 20:05, on Zulip):

the NLL-diagnostics list is long. That is probably the list of items that should be retriaged to stop cluttering up the RC2 milestone

nikomatsakis (Oct 09 2018 at 20:05, on Zulip):

confirm

pnkfelix (Oct 09 2018 at 20:05, on Zulip):

oh i used wrong url before, its NLL-diagnostics for RC2

pnkfelix (Oct 09 2018 at 20:06, on Zulip):

still long but not as bad

pnkfelix (Oct 09 2018 at 20:07, on Zulip):

so an action item (which I'll assign to myself): Before our next weekly meeting, I will go through NLL-diagnostics for RC2 and re-triage them, try to identify if any of them are actual RC2 blockers.

pnkfelix (Oct 09 2018 at 20:07, on Zulip):

Okay. That's all then. Thanks everyone for attending!

Matthew Jasper (Oct 09 2018 at 20:08, on Zulip):

#54779 will need categorizing (it's not going to be ready in 2 weeks most likely)

pnkfelix (Oct 09 2018 at 20:13, on Zulip):

@Matthew Jasper yeah, see here: https://rust-lang.zulipchat.com/#narrow/stream/122657-wg-nll/subject/weekly.20meeting.20October.209/near/135493655

pnkfelix (Oct 09 2018 at 20:13, on Zulip):

which may mean.. we tag #54779 with NLL-deferred ? cc @nikomatsakis

nikomatsakis (Oct 09 2018 at 20:14, on Zulip):

I guess so. I guess that's fine at least until Rust 2018 ships

nikomatsakis (Oct 09 2018 at 20:14, on Zulip):

NLL-deferred is a bit of a grab-bag right now

nikomatsakis (Oct 09 2018 at 20:14, on Zulip):

but we can re-triage it later I guess

Last update: Nov 21 2019 at 15:00UTC