Stream: t-compiler/wg-nll

Topic: triage of A-NLL release milestone issues


pnkfelix (Nov 08 2018 at 14:47, on Zulip):

Just a quick note

pnkfelix (Nov 08 2018 at 14:47, on Zulip):

I'm doing a little subroutine call over here from the T-compiler triage I'm doing

pnkfelix (Nov 08 2018 at 14:47, on Zulip):

as to reduce noise over there

pnkfelix (Nov 08 2018 at 14:48, on Zulip):

I'm going to take "two-phase-borrows need a specification" #46901 off Release milestone, and nominate for discussion at next meeting (Tuesday).

pnkfelix (Nov 08 2018 at 14:50, on Zulip):

next "dropck: track order of destruction for r-value temporaries" #22323

pnkfelix (Nov 08 2018 at 14:50, on Zulip):

this is tagged as NLL-fixed-by-NLL

pnkfelix (Nov 08 2018 at 14:52, on Zulip):

Our policy has to keep such issues open, until NLL becomes the default ... at least for the 2018 release itself. I'm not sure whether we'll continue keeping them open until NLL becomes the default for 2015

pnkfelix (Nov 08 2018 at 14:52, on Zulip):

But It certainly seems like keeping this open is just going to confuse people who are trying to figure out the Release milestone issues.

pnkfelix (Nov 08 2018 at 14:52, on Zulip):

I think the right answer here is to remove NLL-fixed-by-NLL issues from the Release milestone, but continue to leave them open.

davidtwco (Nov 08 2018 at 14:53, on Zulip):

That seems like a sensible approach.

pnkfelix (Nov 08 2018 at 14:58, on Zulip):

Looked next at "NLL reports "borrow used here in later iteration of loop" in cases outside of loop" #53773. It is still a problem.

pnkfelix (Nov 08 2018 at 14:59, on Zulip):

@blitzerr do you think you'll have time to look at this in the near future? It does not appear to have been resolved by PR #54343, despite niko saying it should be

pnkfelix (Nov 08 2018 at 14:59, on Zulip):

(i'm not being fair to niko there; he was really talking about a related issue and saying that a hypothetical ideal fix to it would also resolve this.)

blitzerr (Nov 08 2018 at 15:00, on Zulip):

@pnkfelix I will take a look.

pnkfelix (Nov 08 2018 at 16:14, on Zulip):

it seems like i forgot to write a note here saying that I took "figure out how to integrate constants and the MIR type checker" #46702 off the Release milestone, (and simultaneously I-nominated it for discussion at NLL meeting on Tuesda)

pnkfelix (Nov 08 2018 at 16:14, on Zulip):

@nikomatsakis ^ just thought you should be aware of those changes on #46702 and #46901

Gankro (Nov 10 2018 at 15:46, on Zulip):

what, if anything, is our most comprehensive source of information (documentation) on how NLL works and/or changes things?

Matthew Jasper (Nov 10 2018 at 15:54, on Zulip):

The RFC (unless you consider the compiler "documentation"), maybe Niko's blog posts as well.

Gankro (Nov 10 2018 at 15:58, on Zulip):

What RFC?

Matthew Jasper (Nov 10 2018 at 16:00, on Zulip):

The original NLL RFC (https://rust-lang.github.io/rfcs/2094-nll.html). It's not comprehensive for all the bug fixes and contains position dependent outlives, but I don't think that anyone's written anything better.

Gankro (Nov 10 2018 at 16:01, on Zulip):

hrm, so basically I'll need to pick niko's brain for a picture of the final design?

Matthew Jasper (Nov 10 2018 at 16:14, on Zulip):

Pretty much. To give a very short (and possibly incomprehensible) version of the changes (maybe missing stuff)

Matthew Jasper (Nov 10 2018 at 16:14, on Zulip):

Lifetime inference changes:

Matthew Jasper (Nov 10 2018 at 16:14, on Zulip):

Extras:

Matthew Jasper (Nov 10 2018 at 16:14, on Zulip):

Soundness fixes:

Matthew Jasper (Nov 10 2018 at 16:23, on Zulip):

Oh, and Box gets fully special cased

Gankro (Nov 10 2018 at 16:24, on Zulip):

oh? why?

Matthew Jasper (Nov 10 2018 at 16:31, on Zulip):

I think there's a comment on the tracking issue about this.

DPC (Nov 10 2018 at 22:29, on Zulip):

@Matthew Jasper good idea to post that on irlo or on the nll rfc/tracking issue :)

Matthew Jasper (Nov 10 2018 at 22:32, on Zulip):

Hmm, maybe

Jake Goulding (Nov 10 2018 at 22:43, on Zulip):

Just commit it with the message "come fight me"

Matthew Jasper (Nov 10 2018 at 22:47, on Zulip):

other topic?

Jake Goulding (Nov 11 2018 at 03:16, on Zulip):

indeed :-)

Last update: Nov 21 2019 at 13:25UTC