Stream: t-compiler/wg-nll

Topic: #53764-migrating-run-pass-to-ui


pnkfelix (Aug 31 2018 at 12:31, on Zulip):

I've been making a fair amount of progress on migrating the run-pass tests into ui/run-pass over the past few days

pnkfelix (Aug 31 2018 at 12:32, on Zulip):

initially I had tried to update the tests in some "reasonable" fashion when necessary. But I realized sometime yesterday that doing so probably not a good idea; better, for the initial migration, to try to solely try to add #![allow(...)] to get rid of as much stderr output as possible. and then add .stderr files for the remaining lints that cannot be silenced.

pnkfelix (Aug 31 2018 at 12:32, on Zulip):

(at least, I think this strategy is the best way to optimize ease of review)

pnkfelix (Aug 31 2018 at 12:42, on Zulip):

(the updates I'm talking about are solely to address all the stderr (and a little bit of stdout) output that is produced during any compile, regardless of NLL setting)

pnkfelix (Aug 31 2018 at 12:44, on Zulip):

and in fact, with all those updates in place, the compare-mode=nll run succeeded on the first try! no new bugs found as of yet!

Santiago Pastorino (Aug 31 2018 at 12:45, on Zulip):

:clap::clap::clap:

nikomatsakis (Aug 31 2018 at 13:04, on Zulip):

@pnkfelix awesome! I also agree with #![allow] — in fact, I think that (in general) it is perhaps more reasonable to "allow" lints that are not relevant to the purpose of the test

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

I tend to do that, anyway

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

when adding a run-pass test of my own

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

also, I think that this is super useful work independently of NLL

pnkfelix (Aug 31 2018 at 13:05, on Zulip):

yes it has been very interesting

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

that is, I know that e.g. @Esteban Küber has done things like mining the ui output

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

to get better ideas for error msgs etc

pnkfelix (Aug 31 2018 at 13:05, on Zulip):

I think I have identified at least one test that is UB

pnkfelix (Aug 31 2018 at 13:05, on Zulip):

namely extern-pass-empty.rs

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

it seems like seeing the effects of lints will be helpful to us

nikomatsakis (Aug 31 2018 at 13:05, on Zulip):

nice

pnkfelix (Aug 31 2018 at 13:06, on Zulip):

cases like that, I am going to make sure they are separate commits in my PR, and I will try to remember to also file issues about them.

davidtwco (Aug 31 2018 at 13:07, on Zulip):

If it's anything like the compile-fail migration, I hope you enjoy rebasing :stuck_out_tongue:

pnkfelix (Aug 31 2018 at 15:38, on Zulip):

Yeah at the first sign of rebase trouble, I plan to factor it into several PR's.

pnkfelix (Aug 31 2018 at 15:39, on Zulip):

but I'm hoping there wont be as much rebase trouble since run-pass tests tend not to generate diagnostics

pnkfelix (Aug 31 2018 at 15:40, on Zulip):

(and thus they hopefully will not need updating as frequently. certainly several of these haven't been touched in years...)

pnkfelix (Aug 31 2018 at 15:43, on Zulip):

and in fact, with all those updates in place, the compare-mode=nll run succeeded on the first try! no new bugs found as of yet!

celebration here might have been a little premature, since this first step of migration only grabbed a subset of the files that were directly under src/test/run-pass/. Notably, it did not attempt to migrate any of src/test/run-pass/borrowck/*.rs :oops:

nikomatsakis (Aug 31 2018 at 17:56, on Zulip):

@pnkfelix should I give this PR p=1 you think?

pnkfelix (Aug 31 2018 at 17:57, on Zulip):

I won’t object

pnkfelix (Aug 31 2018 at 17:58, on Zulip):

Though I really do believe it is a bit less likely to fall into rebase-he’ll

nikomatsakis (Aug 31 2018 at 17:59, on Zulip):

would require people modifying run-pass tests

nikomatsakis (Aug 31 2018 at 17:59, on Zulip):

I suppose

nikomatsakis (Aug 31 2018 at 17:59, on Zulip):

and in particular tweaks to error messages don't have any effect?

nikomatsakis (Aug 31 2018 at 17:59, on Zulip):

we have to actually finish these migrations at some point (to keep people from adding new tests...)

nikomatsakis (Aug 31 2018 at 17:59, on Zulip):

we should update the rustc-guide instructions...

nikomatsakis (Aug 31 2018 at 18:00, on Zulip):

well I will leave it as is for now but if it conflicts we'll bump to p=1

nikomatsakis (Aug 31 2018 at 18:00, on Zulip):

I also wanted to give people a chance to speak up

pnkfelix (Sep 17 2018 at 11:49, on Zulip):

Hey @nikomatsakis would you mind just peeking at the followup commits I added to PR #54223 ?

pnkfelix (Sep 17 2018 at 11:49, on Zulip):

The main one I'm potentially concerned about is https://github.com/rust-lang/rust/pull/54223/commits/0f3f1b26870c142e89af3e194544490ae102e3ad

nikomatsakis (Sep 17 2018 at 15:04, on Zulip):

ok

Last update: Nov 21 2019 at 13:50UTC