Stream: t-compiler/wg-nll

Topic: EndRegion


Matthew Jasper (Nov 10 2018 at 21:37, on Zulip):

Would anyone object to the removal of mir::StatementKind::EndRegion? The only reason they have for existing now is if someone wants to inspect them with -Zdump-mir (and -Zemit-end-regions).

Matthew Jasper (Nov 10 2018 at 23:15, on Zulip):

Wow, so much code from lexical MIR borrowck is still around.

Jake Goulding (Nov 11 2018 at 03:16, on Zulip):

I got foiled by Zulip for the first time :-)

Jake Goulding (Nov 11 2018 at 03:17, on Zulip):

I was suggesting that you just submit the PR to remove it with a taunting commit message; make them prove why it's still useful ;-)

lqd (Nov 11 2018 at 15:13, on Zulip):

could the possible tools to visualize regions rely on EndRegion ? this or that

pnkfelix (Nov 11 2018 at 20:26, on Zulip):

@Matthew Jasper I think miri might use EndRegion for its modeling of Invalidating references; cc @RalfJ and @Oli

Matthew Jasper (Nov 11 2018 at 20:38, on Zulip):

I think that's they've moved away from them with #55316 (I guess it might not be completely done on the MIRI side)

RalfJ (Nov 12 2018 at 12:19, on Zulip):

@pnkfelix @Matthew Jasper indeed, EndRegion is no longer used by miri

pnkfelix (Nov 12 2018 at 12:20, on Zulip):

okay then kill it with fire

RalfJ (Nov 12 2018 at 12:20, on Zulip):

please do :)

Matthew Jasper (Nov 14 2018 at 22:19, on Zulip):

:fire: #55959

nikomatsakis (Nov 14 2018 at 22:38, on Zulip):

@Matthew Jasper "Now that lexical MIR borrowck is gone, there's no need to store Regions
unnecessarily." -- what is "lexical MIR borrowck"?

nikomatsakis (Nov 14 2018 at 22:38, on Zulip):

oh right

nikomatsakis (Nov 14 2018 at 22:38, on Zulip):

that's like Ye Olden Days borrowck

nikomatsakis (Nov 14 2018 at 22:38, on Zulip):

from before we made NLL mandatory

nikomatsakis (Nov 14 2018 at 22:38, on Zulip):

/me forgot about that phase altogether

RalfJ (Nov 15 2018 at 08:44, on Zulip):

I assume this means lexical MIR borrowck? The old AST/HIR lexical borrowck is still there, right? (Though it's days are numbered I hear.)

Matthew Jasper (Nov 15 2018 at 09:52, on Zulip):

Correct

Last update: Nov 21 2019 at 13:30UTC