Stream: t-compiler/wg-nll

Topic: edition-triage


nikomatsakis (Jun 29 2018 at 19:33, on Zulip):

I'm going to be triaging issues into editions. Just for fun, I'll try to keep a log on zulip, so you can follow along or tell me what you think if you awnt.

nikomatsakis (Jun 29 2018 at 19:33, on Zulip):

https://github.com/rust-lang/rust/issues/51879

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

this is maybe fixed

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

no

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

I think because of @pnkfelix's PR not having landed then...?

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

hmm, no

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

ok

nikomatsakis (Jun 29 2018 at 19:34, on Zulip):

seems like an easy fix

nikomatsakis (Jun 29 2018 at 19:37, on Zulip):

I'm adding that to the milestone since I think it's easy

nikomatsakis (Jun 29 2018 at 19:38, on Zulip):

https://github.com/rust-lang/rust/issues/51823 -- I will not add this to the milestone since it's kind of a "meta" bug

nikomatsakis (Jun 29 2018 at 19:38, on Zulip):

https://github.com/rust-lang/rust/issues/51821

nikomatsakis (Jun 29 2018 at 19:38, on Zulip):

we have a pending PR

nikomatsakis (Jun 29 2018 at 19:38, on Zulip):

(thanks @Eh2406 ! =)

nikomatsakis (Jun 29 2018 at 19:39, on Zulip):

https://github.com/rust-lang/rust/issues/51820 -- has a pending PR (yay me)

nikomatsakis (Jun 29 2018 at 19:39, on Zulip):

https://github.com/rust-lang/rust/issues/51819 -- has a few pending PRs (yay me, njn)

nikomatsakis (Jun 29 2018 at 19:42, on Zulip):

I'll tag it on the milestone, maybe we'll file some follow-up issues though once those PRs land

nikomatsakis (Jun 29 2018 at 19:42, on Zulip):

https://github.com/rust-lang/rust/issues/51818 -- @Santiago Pastorino is investigating. I'm going to add to milestone, but seems lower priority, if @Santiago Pastorino doesn't get to it, maybe just drop it

nikomatsakis (Jun 29 2018 at 19:49, on Zulip):

@lqd any thoughts about this unused mut — there seem to be a ton of these cases —

nikomatsakis (Jun 29 2018 at 19:50, on Zulip):

I feel like putting them all on a milestone would be annoying

nikomatsakis (Jun 29 2018 at 19:50, on Zulip):

maybe we should make a meta issue

nikomatsakis (Jun 29 2018 at 19:50, on Zulip):

and collect the bugs

lqd (Jun 29 2018 at 19:50, on Zulip):

yeah makes sense, there were a number of those, and I might have missed some "duplicates"

lqd (Jun 29 2018 at 19:52, on Zulip):

and since I touched part of that code recently I think, I could also try fixing it (with a couple of instructions if possible ;)

nikomatsakis (Jun 29 2018 at 19:52, on Zulip):

when there are this many issues, it smells to me like a few underlying bugs

nikomatsakis (Jun 29 2018 at 19:52, on Zulip):

that will be hard to sort out

nikomatsakis (Jun 29 2018 at 19:52, on Zulip):

without trying to fix them

nikomatsakis (Jun 29 2018 at 19:53, on Zulip):

I don't have any tips to give yet, I have to go re-read that code myself :)

lqd (Jun 29 2018 at 19:53, on Zulip):

:)

lqd (Jun 29 2018 at 19:54, on Zulip):

I was thinking it could have been nice to fix before doing the crater run, but hopefully denying all warnings is rare

nikomatsakis (Jun 29 2018 at 19:55, on Zulip):

filed https://github.com/rust-lang/rust/issues/51918

nikomatsakis (Jun 29 2018 at 19:55, on Zulip):

there weren't quite as many duplicates as I thought

lqd (Jun 29 2018 at 19:57, on Zulip):

and that's just the ones I saw from a quick search :) — oh right I was about to point out https://github.com/rust-lang/rust/issues/50897 but you added it already

Matthew Jasper (Jun 29 2018 at 19:58, on Zulip):

I had a look at the unused mut issues.

Matthew Jasper (Jun 29 2018 at 19:59, on Zulip):

Couple of minimised examples:

fn foo(ref x: i32) {}

fn bar() {
    let mut x = 0;
    move || {
        x = 1;
    };
}
Matthew Jasper (Jun 29 2018 at 20:00, on Zulip):

First one is caused by the parameter (what x is a reference to) being given the name x, which means that the lint thinks it's a user variable.

nikomatsakis (Jun 29 2018 at 20:01, on Zulip):

@Matthew Jasper sounds good — maybe leave some notes on #51918?

nikomatsakis (Jun 29 2018 at 20:01, on Zulip):

https://github.com/rust-lang/rust/issues/51759

Matthew Jasper (Jun 29 2018 at 20:01, on Zulip):

I couldn't see anything for the second one.

nikomatsakis (Jun 29 2018 at 20:01, on Zulip):

tagged as "deferred" -- problem pre-exists NLL anyway

Matthew Jasper (Jun 29 2018 at 20:02, on Zulip):

Once we have less terrible free region errors, it probably won't be that bad.

nikomatsakis (Jun 29 2018 at 20:03, on Zulip):

yes. I think that the PR that @David Wood is the first step in that direction. We're going to have to work hard on that.

nikomatsakis (Jun 29 2018 at 20:03, on Zulip):

https://github.com/rust-lang/rust/issues/51710 -- pending PR already (yay @Santiago Pastorino )

nikomatsakis (Jun 29 2018 at 20:03, on Zulip):

https://github.com/rust-lang/rust/issues/51554

nikomatsakis (Jun 29 2018 at 20:04, on Zulip):

current error seems...pretty good

nikomatsakis (Jun 29 2018 at 20:04, on Zulip):
error[E0594]: cannot assign to `*some_name` which is behind a `&` reference
  --> src/main.rs:10:38
   |
10 |         E::Variant(ref some_name) => *some_name += 10,
   |                                      ^^^^^^^^^^^^^^^^ cannot assign
nikomatsakis (Jun 29 2018 at 20:05, on Zulip):

https://github.com/rust-lang/rust/issues/51515 -- has pending PR, adding to milestone

nikomatsakis (Jun 29 2018 at 20:06, on Zulip):

https://github.com/rust-lang/rust/issues/51377 -- closing, basically fine

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

https://github.com/rust-lang/rust/issues/51348 -- hmm

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

I can't decide about this one

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

it's tricky, it would be good to fix, and it's an ICE

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

but it occurs in a relatively narrow set of cases

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

maybe it can be pushed to after the Edition Preview

nikomatsakis (Jun 29 2018 at 20:07, on Zulip):

I'm going to mark it as release candidate but I still kinda want to fix it :stuck_out_tongue:

nikomatsakis (Jun 29 2018 at 20:13, on Zulip):

https://github.com/rust-lang/rust/issues/51217 --

nikomatsakis (Jun 29 2018 at 20:13, on Zulip):

hmm, seems like a fairly minor nit to me

nikomatsakis (Jun 29 2018 at 20:14, on Zulip):

I agree with @pnkfelix that a different span would be better

nikomatsakis (Jun 29 2018 at 20:14, on Zulip):

what do you think @Matthew Jasper :point_up: ? do you have an in-progress PR (you are assigned)

nikomatsakis (Jun 29 2018 at 20:20, on Zulip):

I think I'm going to close some of these bugs around region errors; they are all kind of .. similar-ish

lqd (Jun 29 2018 at 20:20, on Zulip):

(I guess there is still something to fix for https://github.com/rust-lang/rust/issues/51649 ?)

nikomatsakis (Jun 29 2018 at 20:20, on Zulip):

didn't I leavea final comment on there...

lqd (Jun 29 2018 at 20:20, on Zulip):

(or can it be nll-deferred now that it's much less common)

nikomatsakis (Jun 29 2018 at 20:20, on Zulip):

maybe I put it on the wrong issue

nikomatsakis (Jun 29 2018 at 20:21, on Zulip):

yep, I put it on https://github.com/rust-lang/rust/issues/51348

lqd (Jun 29 2018 at 20:22, on Zulip):

:)

nikomatsakis (Jun 29 2018 at 20:23, on Zulip):

I've decided I'll be a bit generous with the Preview 2 milestone

nikomatsakis (Jun 29 2018 at 20:23, on Zulip):

then we can prune later;)

nikomatsakis (Jun 29 2018 at 20:30, on Zulip):

https://github.com/rust-lang/rust/issues/51168 -- a closure case where I think we could do better with relative ease

Matthew Jasper (Jun 29 2018 at 20:32, on Zulip):

@nikomatsakis I have a PR mostly ready for that now that my previous PR is merged. I'll try to get it up tonight.

nikomatsakis (Jun 29 2018 at 20:38, on Zulip):

nice

nikomatsakis (Jun 29 2018 at 20:38, on Zulip):

man triage takes forever

nikomatsakis (Jun 29 2018 at 20:38, on Zulip):

sorry I've been bad about echoing things to zulip :)

nikomatsakis (Jun 29 2018 at 20:39, on Zulip):

down to 29 issues though, at least in one of my lists :)

nikomatsakis (Jun 29 2018 at 20:44, on Zulip):

so .. many .. notes ..

lqd (Jun 29 2018 at 20:45, on Zulip):

btw do we have an idea when felix will be back ?

lqd (Jun 29 2018 at 20:46, on Zulip):

if there's a need to pick up their issues/PRs for the next milestones

lqd (Jun 29 2018 at 21:08, on Zulip):

@nikomatsakis https://github.com/rust-lang/rust/issues/51036#issuecomment-401467561 aren't fcps to rfcbot and not bors ? :)

nikomatsakis (Jun 30 2018 at 09:17, on Zulip):

btw do we have an idea when felix will be back ?

probably around July 5th

nikomatsakis (Jul 03 2018 at 18:33, on Zulip):

OK, I settled on these rules for triaging:

nikomatsakis (Jul 03 2018 at 18:33, on Zulip):

going to try to finish up here

nikomatsakis (Jul 03 2018 at 18:33, on Zulip):

also, I've been marking various issues as I-nominated that I think we should highlight and shoot for closing this week

nikomatsakis (Jul 03 2018 at 19:24, on Zulip):

whew

nikomatsakis (Jul 03 2018 at 19:24, on Zulip):

ok, fully triaged

Last update: Nov 21 2019 at 14:00UTC