I'm happy to try improve this suggestion - does anyone have any thoughts on what we want to do here?
Is this suggestion valid in some circumstances and we could improve the logic with which we deploy the suggestion? Is it always wrong? There are a bunch of places where this suggestion is produced.
I can imagine plenty of places where its valid to say "you don't need to deref here"
(*foo).method() when method is
What are the circumstances in which we produce that suggestion, exactly?
I feel like we should just make no suggestion there
basically, they wrote
*x, if they change to
x, that could be right, but now they have a borrowed thing, so it's quite different from what they had...
It looks like this code produces that.
...e.g., maybe they want to change the function to not borrow?
I don't know, maybe it's fine. I have to run now anyhow...