Stream: t-compiler/wg-nll

Topic: #57804 migrate on 2015 edition


Matthew Jasper (Jan 16 2019 at 21:02, on Zulip):

Hello. So I think this should be possible to do for the 1.34 release (beta cut on 2019-02-28, release on 2019-04-11). I'll post some more here later.

Matthew Jasper (Jan 16 2019 at 21:30, on Zulip):

First some notes on the current open issues. As far as I can tell all blocking issues are marked either P-High or NLL-Sound of those issues the current state is:

Issue number Blocks migrate Assigned To Notes
#46702 Yes matthew/niko Fixed locally
#55748 Yes felix Maybe fixed by #55937? This doesn't appear to be an issue on nightly.
#56254 Yes matthew to me, needs a decision
#57170 Yes matthew Fixed by #57202 - but I'm trying a new (cleaner) approach
#54105 ? niko Is this user visible?
#54940 ? niko Obscure, no easy fix
#46901 No felix We should have some idea what we're allowing for 2 phase borrows
#54943 No? matthew I will try to fix as part of #46702
#56993 No niko I will try to fix as part of #46702
#57374 No lqd/niko Not an issue in migrate mode
Matthew Jasper (Jan 16 2019 at 21:33, on Zulip):

The current state on the 2018 edition is maybe not quite what people think it is. On the 2018 edition:

I propose that we do the same thing on the 2015 edition, meaning that we will always run the NLL borrow checker and always use two-phase borrows.

Matthew Jasper (Jan 16 2019 at 21:36, on Zulip):

Since a lot will change from that I would like to split the work across PRs for the following

davidtwco (Jan 16 2019 at 22:16, on Zulip):

I've reassigned #54943 to you.

Matthew Jasper (Jan 16 2019 at 22:18, on Zulip):

updated

nikomatsakis (Jan 17 2019 at 14:08, on Zulip):

A few questions/comments, @Matthew Jasper:

Matthew Jasper (Jan 17 2019 at 14:27, on Zulip):

I just planned to do them together, although thinking about it some more, I'm not sure if they need to be.

They don't affect migrate mode.

nikomatsakis (Jan 17 2019 at 15:10, on Zulip):

ah, ok

Matthew Jasper (Jan 17 2019 at 18:53, on Zulip):

@nikomatsakis Do you have any thoughts on #54105 and #54940?

nikomatsakis (Jan 17 2019 at 22:09, on Zulip):

Basically I suspect they are non-issues, but I think I would treat them mildly differently --

Jake Goulding (Jan 18 2019 at 01:41, on Zulip):

I'd like to chime in and say I'm super happy to see NLL come to 2015. Thanks for your work! :heart:

pnkfelix (Jan 21 2019 at 14:07, on Zulip):

(I took the liberty of allocating an issue number, #57804, for this worthwhile task.) Thank you for looking into this @Matthew Jasper !

Last update: Nov 21 2019 at 13:10UTC