Stream: t-compiler/wg-nll

Topic: bespoke-relation


nikomatsakis (May 10 2018 at 16:00, on Zulip):

@Chris Vittal btw I rebased the relation branch and pushed some WIP commits starting to add something that uses the edge relation to compute subset relation. I confess I've not yet even tried it. :P

nikomatsakis (May 10 2018 at 16:00, on Zulip):

and we'll need to improve the tests to compare for equality...

nikomatsakis (May 10 2018 at 16:01, on Zulip):

also, it does a bunch of extra work now to compute equal results to timely (e.g., working out the transitive closure), but I figure we can modify how the timing works to just time the "inner loop"

nikomatsakis (May 10 2018 at 16:01, on Zulip):

also I want it known that I am using the word "bespoke" ironically =)

nikomatsakis (May 10 2018 at 16:02, on Zulip):

I'M NOT THAT HIP NORMALLY

nikomatsakis (May 10 2018 at 16:02, on Zulip):

...it is sort of a fun word to say though...

Chris Vittal (May 10 2018 at 16:16, on Zulip):

Alright. I'll take a look. Maybe try to finish it up, add some tests.

nikomatsakis (May 10 2018 at 17:01, on Zulip):

ok, are you actively poking at it? (I am not just now, but might)

Chris Vittal (May 10 2018 at 18:03, on Zulip):

Not right now

nikomatsakis (May 10 2018 at 19:21, on Zulip):

ok so @Chris Vittal I pushed a commit that actually runs the new relation

nikomatsakis (May 10 2018 at 19:21, on Zulip):

it panics :)

nikomatsakis (May 10 2018 at 19:22, on Zulip):

I will look maybe a bit into why, though I was thinking maybe of writing a "naive relation" so I can test the harness itself better...

nikomatsakis (May 10 2018 at 19:34, on Zulip):

oh, the panic turns out to be a bug in the harness definitely

nikomatsakis (May 10 2018 at 21:05, on Zulip):

ok, fixed it, and the test passes now

nikomatsakis (May 10 2018 at 22:33, on Zulip):

(however, running on clap still panics)

nikomatsakis (May 10 2018 at 22:48, on Zulip):

@qmx where'd you push those stats changes?

qmx (May 10 2018 at 22:49, on Zulip):

@nikomatsakis I've forgot to push, will do in a few

qmx (May 10 2018 at 23:04, on Zulip):

@nikomatsakis I'm preparing the PR now, do you want it against another branch than master?

nikomatsakis (May 10 2018 at 23:05, on Zulip):

master would do

nikomatsakis (May 10 2018 at 23:05, on Zulip):

ps we're in the wrong thread :)

nikomatsakis (May 10 2018 at 23:05, on Zulip):

that's the annoying part about threads I guess...

lqd (May 10 2018 at 23:07, on Zulip):

I think you can change the topic when editing a message

nikomatsakis (May 10 2018 at 23:12, on Zulip):

@Chris Vittal ok pushed the driver + tests etc

nikomatsakis (May 10 2018 at 23:12, on Zulip):

er, wait, did my rebase screw something up...

nikomatsakis (May 10 2018 at 23:12, on Zulip):

uh oh

nikomatsakis (May 10 2018 at 23:13, on Zulip):

oh, I see

nikomatsakis (May 10 2018 at 23:16, on Zulip):

ok, now pushed

Chris Vittal (May 10 2018 at 23:30, on Zulip):

got it, what are the current todos?

nikomatsakis (May 10 2018 at 23:30, on Zulip):

well, first off it panics when run against the clap test

nikomatsakis (May 11 2018 at 02:27, on Zulip):

jfyi, I did some experimentation with a matrix version too. Neither one works when deployed at scale =)

nikomatsakis (May 11 2018 at 02:28, on Zulip):

also, I pushed some things to the branch, hopefully won't disturb ya'

Chris Vittal (May 14 2018 at 04:11, on Zulip):

@nikomatsakis Most of what I was able to do this weekend was find a test that reveals a bug in the edge removal code. It's in your repo now. I'll dig into why it fails in the morning.

nikomatsakis (May 14 2018 at 09:10, on Zulip):

ok -- I made great progress on the timely dataflow-based implementation, but I haven't made any more on this

nikomatsakis (May 14 2018 at 14:11, on Zulip):

@Chris Vittal to be perfectly honest, with this PR doing so well, I'm thinking we it's better to stick with differential-dataflow

nikomatsakis (May 14 2018 at 14:12, on Zulip):

though I definitely have no objection to us trying to do better via custom code

Chris Vittal (May 14 2018 at 14:17, on Zulip):

Okay. I'll spend some of today trying to fix it and see where it is with respect to your new PR.

Chris Vittal (May 14 2018 at 14:18, on Zulip):

But I won't take more than today and maybe tomorrow, but considering I have a 10 line test case, it shouldn't be too hard to debug and fix. (I hope)

nikomatsakis (May 14 2018 at 14:19, on Zulip):

we need a :famous last words: emoji

nikomatsakis (May 14 2018 at 14:22, on Zulip):

Zulip does support custom emojis =)

Chris Vittal (May 14 2018 at 20:56, on Zulip):

Okay, I hope that the kinks have been ironed out, but the graph relationship is slow. Slower than even the naive version. shrugs

Chris Vittal (May 14 2018 at 21:06, on Zulip):

@nikomatsakis what now? I could do some of the UI stuff, like command line arguments. But I think further poking on this particular representation may not be a good use of time.

Last update: Nov 21 2019 at 13:15UTC