Stream: t-compiler/wg-nll

Topic: crater-run-review


nikomatsakis (Jul 30 2018 at 15:38, on Zulip):

I'm going over the crater run notes from @lqd, trying to assess our current status. I thought I'd drop some notes in there and in here. (I'm not sure how long i'll be around anyway :)

nikomatsakis (Jul 30 2018 at 15:39, on Zulip):

sadly, the minimized repro from argdata-0.0.4 still seems to be a problem with the July 30 nightly..

nikomatsakis (Jul 30 2018 at 15:39, on Zulip):

..not sure if this has all the fixes?

nikomatsakis (Jul 30 2018 at 15:47, on Zulip):

hmm, I see some that probably need issues filed

nikomatsakis (Aug 06 2018 at 17:17, on Zulip):

so I've created this repository: https://github.com/nikomatsakis/nll-crater-run-results

nikomatsakis (Aug 06 2018 at 17:17, on Zulip):

I'm going through the results

nikomatsakis (Aug 06 2018 at 17:17, on Zulip):

encountered one very strange case, where I have reduced the test case to something small that fails with cargo, but it works when I move it to its own file (?)

nikomatsakis (Aug 06 2018 at 17:18, on Zulip):

(this is the "shred" case)

nikomatsakis (Aug 06 2018 at 17:18, on Zulip):

ah, woah

nikomatsakis (Aug 06 2018 at 17:18, on Zulip):

it has to do with crate-type lib (!)

nikomatsakis (Aug 06 2018 at 17:23, on Zulip):

@simulacrum how long does it take to do another crater run?

nikomatsakis (Aug 06 2018 at 17:23, on Zulip):

seems like a lot of stuff is fixed, might be worth it

nikomatsakis (Aug 06 2018 at 17:23, on Zulip):

are we doing that "in general" as part of EP2 etc?

simulacrum (Aug 06 2018 at 17:58, on Zulip):

~24 hours for a check-only run, around 3 days for full build and test

simulacrum (Aug 06 2018 at 18:20, on Zulip):

Yes, we'll be doing a general run as well

nikomatsakis (Aug 06 2018 at 18:49, on Zulip):

@simulacrum well 1 day is not so bad. Maybe worth it. Not sure. I think we're down to 4 distinct bugs from the previous run

nikomatsakis (Aug 06 2018 at 18:49, on Zulip):

I've filed issues on them now and put them into the Release Candidate triage category, anyway

nikomatsakis (Aug 06 2018 at 18:49, on Zulip):

maybe it can wait

simulacrum (Aug 06 2018 at 18:50, on Zulip):

I think both boxes are busy right now for another ~24-36 hours but craterbot is ready now so we can start builds trivially

nikomatsakis (Aug 06 2018 at 18:51, on Zulip):

amazing

nikomatsakis (Aug 06 2018 at 18:51, on Zulip):

craterbot!

Last update: Nov 21 2019 at 23:30UTC