Stream: t-compiler/wg-nll

Topic: #54586 `unused_mut` lint


nikomatsakis (Oct 02 2018 at 15:21, on Zulip):

@blitzerr I was thinking this would be a good "next PR"

nikomatsakis (Oct 02 2018 at 15:22, on Zulip):

I suspect it's as simple as supressing the message if the variable in question is not marked as "user-defined"

blitzerr (Oct 02 2018 at 15:23, on Zulip):

Sure, I can take a look at that.

blitzerr (Oct 02 2018 at 15:41, on Zulip):

Varkor commented that his his pr will fix the issue. You are not convinced ?

blitzerr (Oct 02 2018 at 15:41, on Zulip):

@nikomatsakis

nikomatsakis (Oct 02 2018 at 15:41, on Zulip):

I am not convinced

nikomatsakis (Oct 02 2018 at 15:41, on Zulip):

I can check though; I'm not sure what @varkor meant by that actually

nikomatsakis (Oct 02 2018 at 15:42, on Zulip):

I think they may have meant that they will be giving more errors earlier on but maybe I misunderstood them

nikomatsakis (Oct 02 2018 at 15:46, on Zulip):

oh, I am totally wrong :)

nikomatsakis (Oct 02 2018 at 15:46, on Zulip):

@varkor did include a fix, though it seems only semi-related to the rest of the PR

nikomatsakis (Oct 02 2018 at 15:47, on Zulip):

that said, the fix looks odd to me :)

nikomatsakis (Oct 02 2018 at 15:47, on Zulip):

but we should find another issue I guess

nikomatsakis (Oct 02 2018 at 15:48, on Zulip):

left a comment; I also think we could make this particular change earlier

blitzerr (Oct 02 2018 at 16:25, on Zulip):

" I also think we could make this particular change earlier"
I didn't get that part

varkor (Oct 02 2018 at 16:39, on Zulip):

sorry, only just seen these messages

varkor (Oct 02 2018 at 16:40, on Zulip):

to summarise: I added a fix for that issue after it appeared as an issue in the uninhabitedness PR — it wasn't immediately related, but because at the time it hadn't been reported, I thought I'd quickly add a fix then and there

varkor (Oct 02 2018 at 16:41, on Zulip):

I was also in a bit of a rush, so my "solution" was a bit hacky

varkor (Oct 02 2018 at 16:41, on Zulip):

I'm testing an updated version now, which seems more like the correct fix

varkor (Oct 02 2018 at 16:42, on Zulip):

didn't realise someone else wanted to look at this, sorry!

nikomatsakis (Oct 02 2018 at 17:42, on Zulip):

@varkor do you plan to open a separate PR with the fix?

varkor (Oct 02 2018 at 23:43, on Zulip):

it depends whether the uninhabited PR seems ready now / very soon — then it'd be slightly less work for bors
I'm happy to split it out into a separate PR if that's clearer, though

varkor (Oct 02 2018 at 23:45, on Zulip):

(I can do that tomorrow if so)

varkor (Oct 03 2018 at 13:15, on Zulip):

I've split out the fix into https://github.com/rust-lang/rust/pull/54787

Last update: Nov 22 2019 at 00:40UTC