Stream: t-compiler/wg-nll

Topic: pr-51729-move-diagnostics

nikomatsakis (Jun 26 2018 at 21:16, on Zulip):

@Matthew Jasper left various nits on #51729, but it looks really lovely. Think you'll be able to add the comments etc + rebase? (I'm asking because I'd rather land it than wait, if that's gonna take a while — but I guess it needs rebase either way)

Matthew Jasper (Jun 27 2018 at 19:38, on Zulip):

re: your last comment, I'm comparing scopes since the alternative was comparing spans that were only used for that. I think I might change back to comparing spans, since I think I'll need them later.

Matthew Jasper (Jun 27 2018 at 19:41, on Zulip):

re: first comment (creating a fake temporary to ensure things are Sized). The temporary is needed to avoid an ICE from box *x where x: Box<[_]>, I don't think the linked PR changes that.

nikomatsakis (Jun 27 2018 at 19:46, on Zulip):

ah, ok

nikomatsakis (Jun 27 2018 at 19:46, on Zulip):

sounds right

Last update: Jul 02 2020 at 13:50UTC