Stream: t-compiler/wg-nll

Topic: #54571 type annot constants


davidtwco (Oct 14 2018 at 19:39, on Zulip):

@nikomatsakis would you be able to provide some high level pointers for this? I've found this part of the code but haven't been able to decipher exactly what it should be in the case of a constant?

davidtwco (Oct 14 2018 at 19:41, on Zulip):

That is, if you aren't already handling it - it was one that you mentioned at the meeting.

nikomatsakis (Oct 15 2018 at 13:11, on Zulip):

Hey @davidtwco — so I just opened https://github.com/rust-lang/rust/pull/55093 and I was planning on tackling constants next, building on that

davidtwco (Oct 15 2018 at 13:13, on Zulip):

If it's a priority then you'll be able to get a PR landed for that quicker than I can, so I don't mind working on something else.

nikomatsakis (Oct 15 2018 at 13:16, on Zulip):

this depends on how much time I have :)

nikomatsakis (Oct 15 2018 at 13:16, on Zulip):

I had meant to open that PR on Thu and hoped to have it landed by today but it wasn't quite ready

davidtwco (Oct 15 2018 at 13:17, on Zulip):

It's been a while since I've done any non-diagnostic PRs so I'm a little rusty.

davidtwco (Oct 15 2018 at 13:17, on Zulip):

Pun not intended.

nikomatsakis (Oct 15 2018 at 13:17, on Zulip):

:)

nikomatsakis (Oct 15 2018 at 13:24, on Zulip):

@davidtwco are you fishing around for a task?

davidtwco (Oct 15 2018 at 13:24, on Zulip):

I've not got anything else in progress at the moment, so yeah.

nikomatsakis (Oct 15 2018 at 13:32, on Zulip):

ok, let me see if I can leave some tips for constants; I've got a few other things to tend to this week so it'd be nice to be not "on the hook" for that PR

nikomatsakis (Oct 15 2018 at 16:29, on Zulip):

@davidtwco ok, I left a comment here

nikomatsakis (Oct 15 2018 at 16:30, on Zulip):

I think this will be fairly easy

nikomatsakis (Oct 15 2018 at 16:30, on Zulip):

I'm happy if you want to take a stab at it, I don't expect to get to it today or at least not for many hours

nikomatsakis (Oct 15 2018 at 16:30, on Zulip):

but if you'd rather not — it's pretty heavily based on my PR — no problem either

davidtwco (Oct 15 2018 at 16:32, on Zulip):

I'll take a look tonight.

davidtwco (Oct 15 2018 at 16:32, on Zulip):

Thanks.

nikomatsakis (Oct 15 2018 at 16:32, on Zulip):

ok, if I do do any hacking, I'll leave some comments, but I don't expect to

nikomatsakis (Oct 16 2018 at 13:45, on Zulip):

@davidtwco did you get a chance to take a look at this?

davidtwco (Oct 16 2018 at 13:47, on Zulip):

I didn't.

davidtwco (Oct 16 2018 at 13:47, on Zulip):

Was busier than expected last night.

nikomatsakis (Oct 16 2018 at 14:20, on Zulip):

ok, I may poke at it this morning, unclear how this day is going to shake it still :)

davidtwco (Oct 16 2018 at 14:20, on Zulip):

Cool, I'll not get a chance to look for a while yet.

nikomatsakis (Oct 16 2018 at 20:52, on Zulip):

ok @davidtwco I didn't do anything here yet :)

nikomatsakis (Oct 16 2018 at 20:53, on Zulip):

I was investigating https://github.com/rust-lang/rust/issues/54940; I tracked down the cause of that, but not sure of the best strategy to fix yet. Could be a royal pain.

nikomatsakis (Oct 17 2018 at 13:31, on Zulip):

@davidtwco did you do anything here, or were you fully occupied with compare-mode etc?

nikomatsakis (Oct 17 2018 at 13:31, on Zulip):

(if not, I might poke at it now)

davidtwco (Oct 17 2018 at 13:31, on Zulip):

I only did the compare-mode stuff yesterday.

nikomatsakis (Oct 17 2018 at 16:00, on Zulip):

ok, I implemented this, fixing one last case

nikomatsakis (Oct 17 2018 at 16:35, on Zulip):

ok, fixing that "one last case" has been a bit trickier than I thought :P

nikomatsakis (Oct 17 2018 at 16:35, on Zulip):

/me hopes they have it now

nikomatsakis (Oct 17 2018 at 16:39, on Zulip):

it works :cold_sweat:

nikomatsakis (Oct 17 2018 at 19:01, on Zulip):

@pnkfelix I left https://github.com/rust-lang/rust/pull/55152 for your review fyi

nikomatsakis (Oct 17 2018 at 20:44, on Zulip):

jfyi @pnkfelix I tagged a few more commits onto #55152, fixing the cast issue as well..

nikomatsakis (Oct 17 2018 at 20:54, on Zulip):

although I wonder if I should break those into a separate PR

nikomatsakis (Oct 17 2018 at 20:54, on Zulip):

they seem to cause some diagnostic fallout

nikomatsakis (Oct 18 2018 at 17:44, on Zulip):

@pnkfelix ok I've resolved I think almost all the fallout but one case. I'm debating how hard to work on that last case.

nikomatsakis (Oct 18 2018 at 17:44, on Zulip):

we basically wind up with duplicate errors sometimes

nikomatsakis (Oct 18 2018 at 17:44, on Zulip):

I think maybe it's worth trying to fix

nikomatsakis (Oct 18 2018 at 17:47, on Zulip):

at least I'll try one simple thing :)

nikomatsakis (Oct 18 2018 at 18:21, on Zulip):

...ok, it worked

Last update: Nov 21 2019 at 15:00UTC