@nikomatsakis would you be able to provide some high level pointers for this? I've found this part of the code but haven't been able to decipher exactly what it should be in the case of a constant?
That is, if you aren't already handling it - it was one that you mentioned at the meeting.
Hey @davidtwco — so I just opened https://github.com/rust-lang/rust/pull/55093 and I was planning on tackling constants next, building on that
If it's a priority then you'll be able to get a PR landed for that quicker than I can, so I don't mind working on something else.
this depends on how much time I have :)
I had meant to open that PR on Thu and hoped to have it landed by today but it wasn't quite ready
It's been a while since I've done any non-diagnostic PRs so I'm a little rusty.
Pun not intended.
@davidtwco are you fishing around for a task?
I've not got anything else in progress at the moment, so yeah.
ok, let me see if I can leave some tips for constants; I've got a few other things to tend to this week so it'd be nice to be not "on the hook" for that PR
@davidtwco ok, I left a comment here
I think this will be fairly easy
I'm happy if you want to take a stab at it, I don't expect to get to it today or at least not for many hours
but if you'd rather not — it's pretty heavily based on my PR — no problem either
I'll take a look tonight.
ok, if I do do any hacking, I'll leave some comments, but I don't expect to
@davidtwco did you get a chance to take a look at this?
Was busier than expected last night.
ok, I may poke at it this morning, unclear how this day is going to shake it still :)
Cool, I'll not get a chance to look for a while yet.
ok @davidtwco I didn't do anything here yet :)
I was investigating https://github.com/rust-lang/rust/issues/54940; I tracked down the cause of that, but not sure of the best strategy to fix yet. Could be a royal pain.
@davidtwco did you do anything here, or were you fully occupied with compare-mode etc?
(if not, I might poke at it now)
I only did the compare-mode stuff yesterday.
ok, I implemented this, fixing one last case
ok, fixing that "one last case" has been a bit trickier than I thought :P
/me hopes they have it now
it works :cold_sweat:
@pnkfelix I left https://github.com/rust-lang/rust/pull/55152 for your review fyi
jfyi @pnkfelix I tagged a few more commits onto #55152, fixing the cast issue as well..
although I wonder if I should break those into a separate PR
they seem to cause some diagnostic fallout
@pnkfelix ok I've resolved I think almost all the fallout but one case. I'm debating how hard to work on that last case.
we basically wind up with duplicate errors sometimes
I think maybe it's worth trying to fix
at least I'll try one simple thing :)
...ok, it worked