its not a big deal; I wrote the comment on a couple PR's but then the comment would get outdated by an update to a the PR
and so it would get hidden
I'll go find the cases where I can remember it
Ah, I always try to make sure I respond to every comment, I’ll try double check that more in future.
This was the second one I wrote; I'm still looking for the first: https://github.com/rust-lang/rust/pull/54831/files#diff-f5a7553f1d02fe100fab92a0f135d0fdR230
There’s no comment there.
If it’s pending you didn’t submit the review.
wait so comments I write don't show up??
That's really frustrating
maybe it makes sense in terms of overall work flow, but the fact that this note is not actually registered for anyone else to see, and that the feedback to me about that is just this
Pending label (which I'm not certain even shows up in the mobile phone interface ...)
I'm now wondering how many comments I've made have been silently discarded due to this...
anyway, sorry, my own github fails are obviously not your problem.
If you put a comment in I'd always respond and try resolve it.
right, but I just didn't know that my comments were being held by github as part of its review system
I understood that it presented me with this embedded choice-box of "approve, reject, etc"
but I assumed that if I didn't make any choice, that my comment would still show up in the meantime and be visible
Normally the "no choice" option is neither approve or reject but just "comment" in that little box.
I now understand that I need to either hit submit (with "no choice") immediately. (That, or I need to finish reading the PR and then make a choice, of course).
but I just didn't know that the way I was using it was broken. Because I don't, you know, visit github issues without being logged in as me
Yeah, it's easy to miss.
anyway I've now identified both the cases where I made the comments and have now submitted them.
Great, I'll get those just now.
w/r/t your comment from earlier - I think it depends when making the review whether you press "add a comment" or "start a review". One of them will add a pending comment to be later be submitted with others all at once; the other will just add it straight away.
it would be nice if there were some indication on the PR of a "review in progress"
Somewhat related, one thing that GitLab does which is nice is in the issue listing, it has a little icon if there's a PR up for that issue. Would be nice for something similar on GitHub, but also a similar icon on PRs for in-progress reviews.
Last time I tried that it made some things look strange so I uninstalled it, might be worth another go. I always wanted this extension to be available for Firefox.