Stream: t-compiler/wg-nll

Topic: edition-schedule-and-nll


nikomatsakis (Jun 29 2018 at 18:04, on Zulip):

So @Santiago Pastorino was talking to me about the edition schedule:

it feels like we really want NLL to be enabled by default by Edition Preview 2

nikomatsakis (Jun 29 2018 at 18:04, on Zulip):

I think we need to think about what are truly blockers for that

nikomatsakis (Jun 29 2018 at 18:04, on Zulip):

my hunch is that we may have to turn our attention somewhat from performance

nikomatsakis (Jun 29 2018 at 18:04, on Zulip):

because that can be iterated on during the RC phase more readily

nikomatsakis (Jun 29 2018 at 18:05, on Zulip):

we should also think about "how fast is fast enough to ship"

nikomatsakis (Jun 29 2018 at 18:05, on Zulip):

I don't have a ready answer for that yet -- it seems like 1.5x is not a good answer. 1.2x though...maybe?

nikomatsakis (Jun 29 2018 at 18:06, on Zulip):

maybe we need to ship along with parallel rustc :stuck_out_tongue:

Santiago Pastorino (Jun 29 2018 at 18:06, on Zulip):

my hunch is that we may have to turn our attention somewhat from performance

yeah, seems like diagnostics is more important, right?

Santiago Pastorino (Jun 29 2018 at 18:06, on Zulip):

performance can be fixed after RC

nikomatsakis (Jun 29 2018 at 18:07, on Zulip):

I guess we need to do a focused triage over all open issues with this in mind

nikomatsakis (Jun 29 2018 at 18:07, on Zulip):

and create a "punchlist"

nikomatsakis (Jun 29 2018 at 18:07, on Zulip):

to that end, the work that @lqd has been doing is invaluable, and I think we should see if we can get that crater run going

nikomatsakis (Jun 29 2018 at 18:08, on Zulip):

hopefully by next Tuesday meeting we can (a) announce victory on performance =) -- by which I mean, we closed the issues we had identified, we got a boost of X% and then (b) focus on the punchlist from that point on until it is closed out

nikomatsakis (Jun 29 2018 at 18:09, on Zulip):

(and then we prioritize from there)

Santiago Pastorino (Jun 29 2018 at 18:10, on Zulip):

seems good

nikomatsakis (Jun 29 2018 at 18:14, on Zulip):

I'll try to spend some time on that this afternoon I think

lqd (Jun 29 2018 at 18:18, on Zulip):

how does the version you profiled earlier with Santiago look perf wise btw ? (as it's kind of a preview of next week's nightly)

nikomatsakis (Jun 29 2018 at 18:24, on Zulip):

the raw numbers looked significantly better to me

nikomatsakis (Jun 29 2018 at 18:25, on Zulip):

I don't usually compare those, more look at percentages, but it seemed like the ratio was noticeably improved from ~1.5 to ~1.3 on my machine

nikomatsakis (Jun 29 2018 at 18:25, on Zulip):

iirc

nikomatsakis (Jun 29 2018 at 18:25, on Zulip):

ratio for clap-rs I mean

nikomatsakis (Jun 29 2018 at 18:25, on Zulip):

but then again maybe it was just some wild and crazy run

lqd (Jun 29 2018 at 18:27, on Zulip):

awesome

lqd (Jun 29 2018 at 18:28, on Zulip):

we'll know for sure soon enough, and most of those PRs have perf runs or will soon have one anyway

nikomatsakis (Jun 29 2018 at 19:28, on Zulip):

seems like one big bit of work is going to be https://github.com/rust-lang/rust/issues/46908

lqd (Sep 05 2018 at 11:02, on Zulip):

@pnkfelix hey Felix :) 2 quick questions:

pnkfelix (Sep 05 2018 at 11:05, on Zulip):

We need 2PB

pnkfelix (Sep 05 2018 at 11:06, on Zulip):

NLL régresses too much stuff otherwise

lqd (Sep 05 2018 at 11:07, on Zulip):

yeah I was mostly wondering if migrate mode also turned them on, or if I had to do it manually, so I enabled 2PB in the off chance migrate didn't

lqd (Sep 05 2018 at 11:14, on Zulip):

and when @pnkfelix or @nikomatsakis are happy with it, we can ask bors for a try build

nikomatsakis (Sep 05 2018 at 13:30, on Zulip):

@lqd happy with what exactly?

lqd (Sep 05 2018 at 13:31, on Zulip):

this https://github.com/rust-lang/rust/pull/53426/commits/423e7f51691c708274f7a709b64ff8ecf14892ad to try and get a perf run for "the future beta" / Edition RC to compare NLL+incr for mw's concern on the NLL tracking issue

nikomatsakis (Sep 05 2018 at 13:47, on Zulip):

I see — looks right to me

lqd (Sep 06 2018 at 07:15, on Zulip):

@simulacrum the try build is ready https://github.com/rust-lang/rust/pull/53426#issuecomment-418829605

Last update: Nov 21 2019 at 13:10UTC