Stream: t-compiler/wg-nll

Topic: how are things looking


nikomatsakis (Oct 29 2018 at 13:06, on Zulip):

@pnkfelix trying to come up to speed — for some reason a bajillion notifications today — how are things looking right now? any last minute fires?

pnkfelix (Oct 29 2018 at 13:07, on Zulip):

no i don't think so

pnkfelix (Oct 29 2018 at 13:07, on Zulip):

I've been working on the .nll.stderr review

pnkfelix (Oct 29 2018 at 13:07, on Zulip):

the two biggest issues I've found are:

pnkfelix (Oct 29 2018 at 13:07, on Zulip):

1. there's one place where borrowck=migrate is mistakenly downgrading an error to a warning

pnkfelix (Oct 29 2018 at 13:08, on Zulip):

(its for some reason missing the error that AST-borrowck does generate)

pnkfelix (Oct 29 2018 at 13:08, on Zulip):

we'll probably want to figure out a fix for that and backport it to beta

pnkfelix (Oct 29 2018 at 13:08, on Zulip):

2. NLL is rejecting a particular use of unions that is supposed to be sound.

pnkfelix (Oct 29 2018 at 13:09, on Zulip):

Neither of these things is worth upsetting the release

pnkfelix (Oct 29 2018 at 13:09, on Zulip):

if you want more info about item 1... I'll probably file a bug about it sometime soonish

pnkfelix (Oct 29 2018 at 13:09, on Zulip):

just wanted to keep going with the .nll.stderr review while I have my groove going

nikomatsakis (Oct 29 2018 at 13:09, on Zulip):

:+1:

nikomatsakis (Oct 29 2018 at 13:10, on Zulip):

ok

pnkfelix (Oct 30 2018 at 13:56, on Zulip):

whoa @simulacrum beta-accepted PR #55494 :)

pnkfelix (Oct 30 2018 at 13:56, on Zulip):

I guess I have no problem with that. I assume the beta-to-be-released this week has already been cut...?

simulacrum (Oct 30 2018 at 16:27, on Zulip):

@pnkfelix Yes, this weeks beta is cut

simulacrum (Oct 30 2018 at 16:28, on Zulip):

The patch looked minimal and we've essentially just cut that beta, also soundness bug -- so all together seemed accept-worthy

Last update: Nov 21 2019 at 13:10UTC