@pnkfelix trying to come up to speed — for some reason a bajillion notifications today — how are things looking right now? any last minute fires?
no i don't think so
I've been working on the .nll.stderr review
the two biggest issues I've found are:
1. there's one place where borrowck=migrate is mistakenly downgrading an error to a warning
(its for some reason missing the error that AST-borrowck does generate)
we'll probably want to figure out a fix for that and backport it to beta
2. NLL is rejecting a particular use of unions that is supposed to be sound.
Neither of these things is worth upsetting the release
if you want more info about item 1... I'll probably file a bug about it sometime soonish
just wanted to keep going with the .nll.stderr review while I have my groove going
whoa @simulacrum beta-accepted PR #55494 :)
I guess I have no problem with that. I assume the beta-to-be-released this week has already been cut...?
@pnkfelix Yes, this weeks beta is cut
The patch looked minimal and we've essentially just cut that beta, also soundness bug -- so all together seemed accept-worthy