Stream: t-compiler/wg-nll

Topic: #53159 hash borrows in scope


nikomatsakis (Aug 10 2018 at 08:59, on Zulip):

@mikhail-m1 (I'm creating a topic to discuss this issue btw)

mikhail-m1 (Aug 13 2018 at 07:51, on Zulip):

hi @nikomatsakis , I on vacation right now, and don't have time to continue work on it in next two or three days and also I have limited access to Internet, I created PR https://github.com/rust-lang/rust/pull/53306 but it affects some error messages, I think because order of checking for borrow conflict is different.

nikomatsakis (Aug 13 2018 at 17:05, on Zulip):

@mikhail-m1 ok! thanks

mikhail-m1 (Aug 22 2018 at 11:29, on Zulip):

@nikomatsakis hi, I updated the PR , but as i said before it affects allot of error messages. May be need to sort borrowed items before check or check how it affects perf?

nikomatsakis (Aug 22 2018 at 11:32, on Zulip):

@mikhail-m1 yeah, probably we want to do both I guess

nikomatsakis (Aug 22 2018 at 11:32, on Zulip):

well, sorting I don't know

nikomatsakis (Aug 22 2018 at 11:32, on Zulip):

I'll take a look later today?

nikomatsakis (Aug 22 2018 at 11:33, on Zulip):

let's get a perf measurement going though. I'm not really sure what effect (if any) this change will have in isolation

lqd (Aug 22 2018 at 14:53, on Zulip):

https://github.com/rust-lang/rust/pull/53306#issuecomment-415030005 == ready for rust-timer :)

lqd (Aug 22 2018 at 15:45, on Zulip):

oh now script-servo fails to build on perf.rlo

Last update: Nov 21 2019 at 23:50UTC