Stream: t-compiler/wg-nll

Topic: borrow-check issue #25


nikomatsakis (May 14 2018 at 14:31, on Zulip):

I just filed borrow-check issue #25, which is to extend the CLI to support passing arguments to differential-dataflow. As @Frank McSherry pointed out, by not doing so, we are not using multiple threads, etc, and it might be nice to see what kind of difference that can make. Should be an easy thing to add if somebody is into it.

qmx (May 14 2018 at 14:33, on Zulip):

I'll tackle this one after 5pm if no one takes it from me before :P

nikomatsakis (May 14 2018 at 14:34, on Zulip):

cool, I left a few notes. I think really we just need to add a -w switch

Pramod Bisht (May 15 2018 at 18:45, on Zulip):

@qmx can I take this on, if you are not working on this :P

qmx (May 15 2018 at 18:55, on Zulip):

go for it!

Pramod Bisht (May 15 2018 at 18:58, on Zulip):

@qmx: you did not start working on that right?

qmx (May 15 2018 at 19:18, on Zulip):

I did, and that's fine :)

Pramod Bisht (May 15 2018 at 19:37, on Zulip):

@nikomatsakis @qmx could you check this https://github.com/rust-lang-nursery/borrow-check/pull/30
I don't know how to test multiple worker things, Could you help me on that? please let me know if I need to support other arguments apart of worker.

nikomatsakis (May 15 2018 at 19:39, on Zulip):

left a few comments

Pramod Bisht (May 16 2018 at 04:46, on Zulip):

@nikomatsakis for helper function, any ideal place where I should store that? or should I create common helper functions file for that?

nikomatsakis (May 16 2018 at 08:17, on Zulip):

@Pramod Bisht I guess something a module like output::timely_util would be fine

Pramod Bisht (May 16 2018 at 09:56, on Zulip):

:thumbs_up:

Pramod Bisht (May 16 2018 at 17:02, on Zulip):

@nikomatsakis done

nikomatsakis (May 16 2018 at 20:46, on Zulip):

@Pramod Bisht merged

Pramod Bisht (May 17 2018 at 05:09, on Zulip):

@nikomatsakis :thumbs_up:

Last update: Nov 22 2019 at 00:35UTC