Stream: t-compiler/wg-nll

Topic: #56477 closure constraint generation


nikomatsakis (Dec 04 2018 at 19:11, on Zulip):

@Matthew Jasper any updates on the build failure in #56486 ?

nikomatsakis (Dec 04 2018 at 19:11, on Zulip):

looks like a pretty bad bug :)

Matthew Jasper (Dec 04 2018 at 19:15, on Zulip):

Failure is legit, but pretty easy to fix AFAICT (type_of shouldn't be called with a local tcx)

Matthew Jasper (Dec 04 2018 at 19:15, on Zulip):

Doing a local build now to check if there's further fallout

nikomatsakis (Dec 04 2018 at 19:19, on Zulip):

@Matthew Jasper question: @Alex Crichton suggests we could do another build with this PR

nikomatsakis (Dec 04 2018 at 19:19, on Zulip):

so the question is, would we rather try to get this in the release, or address via a patch release?

nikomatsakis (Dec 04 2018 at 19:19, on Zulip):

do you have a sense for that?

Matthew Jasper (Dec 04 2018 at 19:43, on Zulip):

I think this probably should be a patch to 1.31. It seems likely that someone will end up writing code that breaks from this.

Matthew Jasper (Dec 04 2018 at 20:19, on Zulip):

OK, build should be green now.

nikomatsakis (Dec 04 2018 at 20:58, on Zulip):

ok, thanks

Matthew Jasper (Dec 04 2018 at 20:58, on Zulip):

And it's testing now

Pietro Albini (Dec 04 2018 at 21:05, on Zulip):

we might include this in the 1.31.0 release

Alex Crichton (Dec 04 2018 at 21:11, on Zulip):

Ok we've discussed on discord and plan to try to include this, we'll do our best!

Last update: Nov 21 2019 at 13:10UTC