Stream: t-compiler/wg-nll

Topic: milestone adjustments


nikomatsakis (Oct 17 2018 at 21:30, on Zulip):

I was asked to pare down the Rust 2018 RC 2 blockers to the true blockers. As a result, I moved:

pnkfelix (Oct 17 2018 at 22:11, on Zulip):

I do wonder whether, once PR #55134 lands, if there some faster methodology we could use to try to identify the potential soundness issues

pnkfelix (Oct 17 2018 at 22:11, on Zulip):

ie.. a lighter weight, more directed version of #54528 for the RC2

pnkfelix (Oct 17 2018 at 22:12, on Zulip):

I think my biggest fear is the set of tests where a whole bunch of distinct cases are all in one file

pnkfelix (Oct 17 2018 at 22:13, on Zulip):

If the different cases were in different files, then we'd immediately see the instances where AST-borrowck flagged an error and MIR-borrowck did not (and then review those)

pnkfelix (Oct 17 2018 at 22:13, on Zulip):

but the way things stand... its a bit harder to tease out the deltas from the diffs of the .stderr files

pnkfelix (Oct 17 2018 at 22:14, on Zulip):

I guess this is my long winded way of saying: I don't disagree with the milestone adjustment for #54528, based on an assumption that chances are high that we've already identified the soundness issues that were going to be uncovered via that methodology

pnkfelix (Oct 17 2018 at 22:15, on Zulip):

and therefore the main things remaining are just completeness (which wont be much, if anything) and diagnostic quality (which given the current state of things, should not be an RC2 blocker IMO).

nikomatsakis (Oct 18 2018 at 09:32, on Zulip):

@pnkfelix so the current list of blockers is .. not short

nikomatsakis (Oct 18 2018 at 09:32, on Zulip):

NLL blockers, that is

nikomatsakis (Oct 18 2018 at 09:33, on Zulip):

I think some of them should be "demoted"

nikomatsakis (Oct 18 2018 at 09:36, on Zulip):

Some candidates to be demoted to release milestone:

Some things I am unsure about:

The rest have pending fixes and/or are deep in progress:

pnkfelix (Oct 18 2018 at 09:44, on Zulip):

I don’t object to demoting the ones you listed as well as the ones you were less sure about

pnkfelix (Oct 18 2018 at 09:45, on Zulip):

I’ll try to have status update on mine later today. #things on plate is reduced but still a lot going on at moment

Santiago Pastorino (Oct 18 2018 at 16:10, on Zulip):

Some candidates to be demoted to release milestone:

Some things I am unsure about:

The rest have pending fixes and/or are deep in progress:

@nikomatsakis I guess starting tomorrow night I will have time to spend on this, we can even go after it together during the conf?

Santiago Pastorino (Oct 20 2018 at 15:02, on Zulip):

@nikomatsakis I guess you pointed to the wrong issue, is #54124 the one we are talking about, right?

Santiago Pastorino (Oct 20 2018 at 15:02, on Zulip):

the last 2 numbers are flipped

nikomatsakis (Oct 22 2018 at 15:39, on Zulip):

@Santiago Pastorino where did I flip the numbers?

nikomatsakis (Oct 22 2018 at 15:39, on Zulip):

I do that a lot

Santiago Pastorino (Oct 22 2018 at 20:08, on Zulip):

@nikomatsakis don't worry is not important :)

Santiago Pastorino (Oct 22 2018 at 20:09, on Zulip):

Some candidates to be demoted to release milestone:

Some things I am unsure about:

The rest have pending fixes and/or are deep in progress:

but it was here you said #54142 and was #54124

Last update: Nov 21 2019 at 13:05UTC