Stream: t-compiler/wg-nll

Topic: #54329 the great rollup PR

pnkfelix (Sep 18 2018 at 20:13, on Zulip):

lets get this party started

nikomatsakis (Sep 18 2018 at 20:13, on Zulip):

I started putting comments

pnkfelix (Sep 18 2018 at 20:29, on Zulip):

@nikomatsakis what are your thoughts on PR #54164? Should I try to include it?

nikomatsakis (Sep 18 2018 at 20:33, on Zulip):

@pnkfelix not quite yet, I had a review (jsut posted it)

lqd (Sep 19 2018 at 07:06, on Zulip):

#53995 is referenced on GH for the rollup, but was already r+ed, and just landed

pnkfelix (Sep 19 2018 at 08:28, on Zulip):

@lqd thanks. Yeah I figured I might be taking part in a race

pnkfelix (Sep 19 2018 at 08:28, on Zulip):

(I was too tired to wait for my first build to finish last night)

pnkfelix (Sep 19 2018 at 08:43, on Zulip):

interestingly, so far it seems like there were no conflicts in the code...?

pnkfelix (Sep 19 2018 at 08:44, on Zulip):

(doing a build+test run now. I feel like it may not be worth making a separate PR for this if the merges are clean and there are only two PR's in it...)

lqd (Sep 19 2018 at 08:49, on Zulip):

nice, pleasantly surprised about the lack of conflicts, with everyone modifying error_reporting and the likes

Last update: Jul 14 2020 at 13:00UTC