Stream: zulip

Topic: alexcrichton/jemallocator#64 test


pnkfelix (Nov 06 2018 at 10:54, on Zulip):

test

davidtwco (Nov 06 2018 at 10:54, on Zulip):

there are linkifiers set up for chalk and polonius but nothing else currently

pnkfelix (Nov 06 2018 at 10:55, on Zulip):

thanks. too bad.

davidtwco (Nov 06 2018 at 10:55, on Zulip):

You can only use one capture variable in the linkifier so I don't think we can make it generic enough to build any arbitrary GitHub url.

pnkfelix (Nov 06 2018 at 10:56, on Zulip):

I don't quite understand the architecture of what you describe, so I'm missing context

davidtwco (Nov 06 2018 at 10:56, on Zulip):

Can see it on "Organization Settings > Linkifiers" from the cog in the top right of Zulip.

pnkfelix (Nov 06 2018 at 10:56, on Zulip):

you cannot make a regexp that would match org/project#issuenum ?

davidtwco (Nov 06 2018 at 10:56, on Zulip):

It's basically a regex.

pnkfelix (Nov 06 2018 at 10:56, on Zulip):

Can see it on "Organization Settings > Linkifiers" from the cog in the top right of Zulip.

/me looks

davidtwco (Nov 06 2018 at 10:56, on Zulip):

I think we tried making it more generic and supporting arbitrary GitHub projects but I don't think it would let us.

pnkfelix (Nov 06 2018 at 10:58, on Zulip):

I see, I should be able to add a new linkifier there, so in theory there's no harm in trying. But I suspect I'm not likely to succeed if others have already tried this...

davidtwco (Nov 06 2018 at 10:58, on Zulip):

I just tried it on a private instance I've got for messing around: pasted image

davidtwco (Nov 06 2018 at 10:59, on Zulip):

Seems like they validate the URL format string in a too restrictive way.

davidtwco (Nov 06 2018 at 11:00, on Zulip):

Can't put links in topic titles either since there's a length cap.

pnkfelix (Nov 06 2018 at 11:00, on Zulip):

Oh! hmm, right. I had thought we could get away with just feeding in the whole captured text directly, but you're right; we'd need to inject "issues/" into the middle of the string... hmmm..

davidtwco (Nov 06 2018 at 11:02, on Zulip):

Unless there's some service out there that will take "alexcrichton/jemallocator#6" and redirect you to the GitHub page - then we could do it as one variable.

davidtwco (Nov 06 2018 at 11:02, on Zulip):

That'd be easy enough to make.

pnkfelix (Nov 06 2018 at 11:07, on Zulip):

a service called "github flavored markdown" ...

pnkfelix (Nov 06 2018 at 11:07, on Zulip):

:wink:

davidtwco (Nov 06 2018 at 11:09, on Zulip):

Actually, wouldn't be as easy, no server would be able to intercept the anchor and redirect it without some JS on the page doing that.

davidtwco (Nov 06 2018 at 11:19, on Zulip):

I've set up https://github-expander.dtw.io/alexcrichton/jemallocator/6 - with any repo it'll work.

davidtwco (Nov 06 2018 at 11:19, on Zulip):

We could set up a linkifier to match x/y/n and just pop that on the end of github-expander.dtw.io/ and it'd work.

davidtwco (Nov 06 2018 at 11:20, on Zulip):

It's not as nice as I can't use # but it's not awful.

davidtwco (Nov 06 2018 at 11:24, on Zulip):

Confirmed that this will work: pasted image

davidtwco (Nov 06 2018 at 11:24, on Zulip):

Might be a nice fallback for repos like this and we can keep the special casing directly for repos we reference all the time.

pnkfelix (Nov 06 2018 at 11:52, on Zulip):

hmm why can't it use #?

pnkfelix (Nov 06 2018 at 11:52, on Zulip):

oh you can't put it into the url ?

davidtwco (Nov 06 2018 at 11:52, on Zulip):

Part of the spec that defines urls mandates that # is handled client-side only.

pnkfelix (Nov 06 2018 at 11:52, on Zulip):

hmmmm......

davidtwco (Nov 06 2018 at 11:52, on Zulip):

So I can't use that in doing the redirects.

davidtwco (Nov 06 2018 at 11:52, on Zulip):

And therefore can't use it in the pattern.

davidtwco (Nov 06 2018 at 11:52, on Zulip):

Since that just gets appended on a URL.

DPC (Nov 06 2018 at 19:15, on Zulip):

maybe post a request to the zulip person on internals asking him if this can be done? will be helpful if #crate/xxx streams becomes a reality

Last update: Nov 17 2019 at 07:35UTC