Stream: general

Topic: ignore-pass


RalfJ (Aug 02 2019 at 20:58, on Zulip):

Is it just me or is the new ignore-pass directive for UI tests confusing? Usually ignore-X means "ignore this test if X applies", like ignore-windows or ignore-x86 or so. but ignore-pass means "ignore --pass argument"...

RalfJ (Aug 02 2019 at 20:58, on Zulip):

@centril AFAIK you were involved in the recent UI test changes

centril (Aug 02 2019 at 20:59, on Zulip):

@RalfJ I think it could be better named

centril (Aug 02 2019 at 20:59, on Zulip):

ideally the directive shouldn't exist

RalfJ (Aug 02 2019 at 20:59, on Zulip):

I also find --pass build confusing TBH

centril (Aug 02 2019 at 20:59, on Zulip):

elaborate?

RalfJ (Aug 02 2019 at 20:59, on Zulip):

it reads to be either as "pass build to... something (as an argument)" or "make all build tests pass" or so

centril (Aug 02 2019 at 21:00, on Zulip):

@RalfJ I see yes... I think it's a concession to brevity

centril (Aug 02 2019 at 21:00, on Zulip):

I would love to find something relatively as brief but more clear

RalfJ (Aug 02 2019 at 21:00, on Zulip):

other times it sounds like doing something with "the build pass"

RalfJ (Aug 02 2019 at 21:01, on Zulip):

"pass" is just way too overloaded in compilers/languages^^

centril (Aug 02 2019 at 21:01, on Zulip):

but it's something of a tall order to improve clarity without making it longer

RalfJ (Aug 02 2019 at 21:01, on Zulip):

yeah

centril (Aug 02 2019 at 21:01, on Zulip):

fwiw, it does have a help explanation ^^

centril (Aug 02 2019 at 21:01, on Zulip):

but // ignore-pass could be longer if that helps

centril (Aug 02 2019 at 21:02, on Zulip):

maybe // ignore-pass-flag

centril (Aug 02 2019 at 21:02, on Zulip):

Ideally we would remove the need for it tho

centril (Aug 02 2019 at 21:02, on Zulip):

that's where I'd spend my energy

RalfJ (Aug 02 2019 at 21:03, on Zulip):

I think t cannot start with ignore

RalfJ (Aug 02 2019 at 21:03, on Zulip):

pass-ignore or so might work

RalfJ (Aug 02 2019 at 21:03, on Zulip):

"force {check,build,run}-pass tests to this mode."
so a test that's usually check-pass will be run when using --pass run?

centril (Aug 02 2019 at 21:03, on Zulip):

@RalfJ correct

RalfJ (Aug 02 2019 at 21:04, on Zulip):

hm, odd. I would have expected a cap instead

RalfJ (Aug 02 2019 at 21:04, on Zulip):

seems weird to test more than what the test itself says to test

centril (Aug 02 2019 at 21:04, on Zulip):

@RalfJ that was my thinking originally

centril (Aug 02 2019 at 21:04, on Zulip):

not sure why it changed

centril (Aug 02 2019 at 21:04, on Zulip):

9/10 times you want --pass check anyways

centril (Aug 02 2019 at 21:05, on Zulip):

maybe it should be changed to a cap;

cc @Vadim Petrochenkov

RalfJ (Aug 02 2019 at 21:05, on Zulip):

--check/--build/--run might work as flags

centril (Aug 02 2019 at 21:06, on Zulip):

sure

RalfJ (Aug 02 2019 at 21:06, on Zulip):

its more flags, but its both shorter and less confusing than the current situation IMO

centril (Aug 02 2019 at 21:06, on Zulip):

The current situation works for me tho so I'm not going to change it myself but if you feel strongly make an issue or something :P

RalfJ (Aug 02 2019 at 21:07, on Zulip):

I'll see if I get bored over the weekend ;)

centril (Aug 02 2019 at 21:07, on Zulip):

:joy:

Vadim Petrochenkov (Aug 02 2019 at 21:20, on Zulip):

--pass run is needed.
Over the time tests will be migrated to weaker testing modes (like // check-pass) and weird unpredictable codegen bugs will inevitably slip through this weaker testing.
Occasional (or regular, if CI allows) --pass run runs will ensure that it doesn't happen.

Vadim Petrochenkov (Aug 02 2019 at 21:23, on Zulip):

I originally wanted to implement the spectrum of pass mode tweaks - >=mode, <=mode etc.
The initial implementation only did ==mode, but that's not the end of the story.

Vadim Petrochenkov (Aug 02 2019 at 21:26, on Zulip):

I don't like --check/--build/--run because the options apply only to pass tests.
run-fail tests will still be fully built and run even in the --pass check mode.

Vadim Petrochenkov (Aug 02 2019 at 21:27, on Zulip):

I originally wanted to implement the full spectrum of pass mode tweaks - >=mode, <=mode etc.

That said, I didn't need the modes using the "cap" meaning yet.

RalfJ (Aug 02 2019 at 21:27, on Zulip):

but it is entirely unclear that "pass" is an adjective for the kind of test here

RalfJ (Aug 02 2019 at 21:28, on Zulip):

almost always it is used as a verb or a noun

RalfJ (Aug 02 2019 at 21:28, on Zulip):

so even with your valid criticism I still think the bare flags are clearer^^

Vadim Petrochenkov (Aug 02 2019 at 21:28, on Zulip):

--pass-mode?

RalfJ (Aug 02 2019 at 21:29, on Zulip):

still snaps to a verb in my brain

Vadim Petrochenkov (Aug 02 2019 at 21:29, on Zulip):

It's just a thing for every day use, so I'd personally prefer it to be short and people being sent to read what it does in the docs.

RalfJ (Aug 02 2019 at 21:29, on Zulip):

maybe passing works better than pass?

RalfJ (Aug 02 2019 at 21:30, on Zulip):

though -fail tests also better pass^^

RalfJ (Aug 02 2019 at 21:30, on Zulip):

IOW, the terminology is confusing even outside the flag

Vadim Petrochenkov (Aug 02 2019 at 21:31, on Zulip):

¯\_(ツ)_/¯

Vadim Petrochenkov (Aug 02 2019 at 21:32, on Zulip):

but it is entirely unclear that "pass" is an adjective for the kind of test here

--pass is a verb though?

Vadim Petrochenkov (Aug 02 2019 at 21:32, on Zulip):

pass [through a] build, pass [through a] run

RalfJ (Aug 02 2019 at 21:33, on Zulip):

oh that's how you think about it

RalfJ (Aug 02 2019 at 21:33, on Zulip):

the verb I meant is to "pass an argument" or "pass sth along"

Vadim Petrochenkov (Aug 02 2019 at 21:34, on Zulip):

I wonder why run-pass was originally not named pass-run...

Vadim Petrochenkov (Aug 02 2019 at 21:35, on Zulip):

Probably because the "more important" thing were put first?

RalfJ (Aug 02 2019 at 21:36, on Zulip):

--run-pass, --check-pass, --build-pass?

RalfJ (Aug 02 2019 at 21:37, on Zulip):

maybe it's just because I have seen "run-pass" for years now, but those "click" the right way for me

Vadim Petrochenkov (Aug 02 2019 at 21:37, on Zulip):

--run-pass etc LGTM.

Vadim Petrochenkov (Aug 02 2019 at 21:37, on Zulip):

Will be harder to extend the syntax to >= naturally though.

Vadim Petrochenkov (Aug 02 2019 at 21:38, on Zulip):

(If it ever becomes necessary at all.)

RalfJ (Aug 02 2019 at 21:38, on Zulip):

yeah

Vadim Petrochenkov (Aug 02 2019 at 21:39, on Zulip):

--run-pass also looks like a filter, like "run the run-pass tests only".

RalfJ (Aug 03 2019 at 09:43, on Zulip):

I dont think it looks any more like a filter than --pass run

Last update: Nov 22 2019 at 00:30UTC