Stream: general

Topic: bootstrap: Mode::ToolStd vs ToolTest vs ToolRustc


RalfJ (Jul 31 2019 at 06:56, on Zulip):

bootstrap defines a bunch of "modes to invoke cargo", and three of them are collected under a single doccomment: ToolStd, ToolTest, ToolRustc. Is there any difference between them? If yes, would be nice if that could be documented; if no, what about just removing two of them?
Cc @simulacrum

RalfJ (Jul 31 2019 at 06:58, on Zulip):

In particular it seems odd that the tool tests (at least for miri and rustfmt which I checked) use ToolRustc as opposed to ToolTest

RalfJ (Jul 31 2019 at 07:00, on Zulip):

ToolTest seems to be used only once, in TestLink::run (which I think is about libtest?)

RalfJ (Jul 31 2019 at 07:01, on Zulip):

(and that's for running the "clean" command... weird)

simulacrum (Jul 31 2019 at 10:53, on Zulip):

@RalfJ they're used to determine dependencies and when to delete miri so it can be rebuilt

simulacrum (Jul 31 2019 at 10:53, on Zulip):

So because miri needs e.g. librustc_mir it's a ToolRustc

RalfJ (Jul 31 2019 at 14:56, on Zulip):

okay... so the three different modes correspond to needing different amounts of other stuff?

RalfJ (Jul 31 2019 at 14:56, on Zulip):

could you add comments saying what it is that they each reflect in terms of dependencies (or I could also add that based on what you tell me, not sure if that would be any simpler^^)

Last update: Nov 20 2019 at 12:50UTC