Stream: general

Topic: thanks.rust-lang.org


RalfJ (Feb 13 2020 at 08:55, on Zulip):

Can anyone explain how the numbers of https://thanks.rust-lang.org/rust/all-time/ come to be? There is no way I should be above eddy and greydon (both are before me on https://github.com/rust-lang/rust/graphs/contributors), just to name two.

davidtwco (Feb 13 2020 at 09:00, on Zulip):

Just guessing, but I think it counts all repositories in the organisation?

matprec (Feb 13 2020 at 09:01, on Zulip):

https://thanks.rust-lang.org/about/ says that it counts some submodules, so probably your commits in miri get counted as well?

RalfJ (Feb 13 2020 at 09:02, on Zulip):

hm, but even then this feels too high

RalfJ (Feb 13 2020 at 09:02, on Zulip):

and it also feels like cheating as I have tons of tiny commits there^^

RalfJ (Feb 13 2020 at 09:03, on Zulip):

(well already in rustc, as you can see on the GH side... @centril has more than twice as many lines as I do but with 300 commits less^^)

Zoxc (Feb 13 2020 at 09:06, on Zulip):

Mine's a nice even number. I should stop contributing at this point =P

matprec (Feb 13 2020 at 09:10, on Zulip):

@RalfJ

{
  "data": {
    "user": {
      "login": "RalfJung",
      "id": "MDQ6VXNlcjMzMDYyOA=="
    },
    "organization": {
      "miri": {
        "defaultBranchRef": {
          "target": {
            "history": {
              "totalCount": 1554
            }
          }
        }
      },
      "rust": {
        "defaultBranchRef": {
          "target": {
            "history": {
              "totalCount": 1476
            }
          }
        }
      }
    }
  }
}
matprec (Feb 13 2020 at 09:11, on Zulip):

Query used:

{
  user(login: "RalfJung") {
    login
    id
  }
  organization(login: "rust-lang") {
    miri: repository(name: "miri") {
      defaultBranchRef {
        target {
          ... on Commit {
            history(author: {id: "MDQ6VXNlcjMzMDYyOA=="}) {
              totalCount
            }
          }
        }
      }
    }
    rust: repository(name: "rust") {
      defaultBranchRef {
        target {
          ... on Commit {
            history(author: {id: "MDQ6VXNlcjMzMDYyOA=="}) {
              totalCount
            }
          }
        }
      }
    }
  }
}
RalfJ (Feb 13 2020 at 09:17, on Zulip):

Mine's a nice even number. I should stop contributing at this point =P

there's also "Zoxc: 1" so it's not actually that even :P

RalfJ (Feb 13 2020 at 09:18, on Zulip):

@matprec thanks, that at least explains where the number is coming from. still seems odd to me if the result is that I am before eddy or centril or steve.

simulacrum (Feb 13 2020 at 12:12, on Zulip):

We count both commits and review approvals. The exact number is a bit questionable, but ultimately it's not meant to mean anything anyway.

simulacrum (Feb 13 2020 at 12:19, on Zulip):

I've debated removing it entirely and just randomly or alphabetically ordering.

nagisa (Feb 13 2020 at 16:16, on Zulip):

yeah, ordering thanks lists "in no particular order" is meant to avoid exactly this issue

Last update: Feb 25 2020 at 04:25UTC