Stream: general

Topic: RFC labels


RalfJ (Nov 26 2018 at 14:41, on Zulip):

@Mazdak Farrokhzad those new RFC labels... they have the wrong color :scream:

centril (Nov 26 2018 at 14:41, on Zulip):

I'm open to suggestions...

RalfJ (Nov 26 2018 at 14:46, on Zulip):

consistent with the rustc repo?

Pietro Albini (Nov 26 2018 at 14:46, on Zulip):

are you really considering changing the color of all those labels?

centril (Nov 26 2018 at 14:51, on Zulip):

@RalfJ I didn't find that color particularly readable; but I'll change to something adjacent? #f7e101

RalfJ (Nov 26 2018 at 15:27, on Zulip):

I just really love consistency...

RalfJ (Nov 26 2018 at 15:27, on Zulip):

dont care about the particular color, but it should be the same

centril (Nov 26 2018 at 15:46, on Zulip):

@RalfJ I changed all the colors on both repos to #f7e101

Vadim Petrochenkov (Nov 26 2018 at 17:29, on Zulip):

There are... so many labels.

Vadim Petrochenkov (Nov 26 2018 at 17:30, on Zulip):

I'm afraid only @Mazdak Farrokhzad will remember what labels exist and appropriate for a given PR/issue.

centril (Nov 26 2018 at 17:31, on Zulip):

@Vadim Petrochenkov true; there were a lot of RFCs to cover; -- I think you can type the thing that pops into your mind when reading the RFC and the searching functionality should give you something

centril (Nov 26 2018 at 17:31, on Zulip):

since that's the way I created all of the labels

centril (Nov 26 2018 at 17:31, on Zulip):

also, I do all the labeling of RFCs anyways ;)

Vadim Petrochenkov (Nov 26 2018 at 17:31, on Zulip):

I thought about having maybe 10-15 of them or so.
One for lexer things, one for syntax things, one for name resolution things, etc.

Vadim Petrochenkov (Nov 26 2018 at 17:32, on Zulip):

Not so fine-grained.

centril (Nov 26 2018 at 17:32, on Zulip):

there are coarse grained labels and more fine grained ones

centril (Nov 26 2018 at 17:32, on Zulip):

e.g. A-syntax covers all syntax changes

Vadim Petrochenkov (Nov 26 2018 at 17:33, on Zulip):

also, I do all the labeling of RFCs anyways ;)

Bus factor.

centril (Nov 26 2018 at 17:35, on Zulip):

I don't think it's that hard to see what labels are appropriate honestly by looking at a few RFCs and the number of labels are similar to the rust repo

centril (Nov 26 2018 at 17:47, on Zulip):

there's still a lot of stuff to label: all the issues (open & closed) and all the closed unmerged PRs

centril (Nov 26 2018 at 17:47, on Zulip):

so I need to label those before tweaking the number of labels

Last update: Nov 20 2019 at 12:45UTC