Stream: general

Topic: miri checkout


Jethro (Dec 07 2018 at 05:33, on Zulip):

With the latest master, I'm having trouble updating the miri submodule:

$ git submodule update --init --recursive
fatal: reference is not a tree: 61f20761d3124f5a1b1caee8aa15637cc7f92d8e
Unable to checkout '61f20761d3124f5a1b1caee8aa15637cc7f92d8e' in submodule path 'src/tools/miri'

Any ideas?

Jethro (Dec 07 2018 at 05:47, on Zulip):

https://github.com/rust-lang/rust/pull/56307#issuecomment-445128716

oli (Dec 07 2018 at 07:51, on Zulip):

that's weird. I'll address it in 30mins when I arrive at a PC. Should be trivial

RalfJ (Dec 07 2018 at 10:25, on Zulip):

@Jethro which git version are you using?

RalfJ (Dec 07 2018 at 10:27, on Zulip):

it works fine locally and on CI...

RalfJ (Dec 07 2018 at 10:27, on Zulip):

now the commit is in a branch in the repo

RalfJ (Dec 07 2018 at 10:27, on Zulip):

it cannot be in master because it doesnt pass CI yet because it is waiting for a new nightly to happen and for some reason no nightly happened last night

RalfJ (Dec 07 2018 at 10:27, on Zulip):

so @Jethro could you try again?

RalfJ (Dec 07 2018 at 10:27, on Zulip):

(context: the commit was in a PR but not in a branch in the repo, it might be old versions of git cannot fetch that)

Jethro (Dec 07 2018 at 10:34, on Zulip):

git version 2.7.4 (comes with Ubuntu 16.04)

Jethro (Dec 07 2018 at 10:34, on Zulip):

it seems to be resolved now (but I'm on mobile so not 100% sure)

Jethro (Dec 07 2018 at 10:35, on Zulip):

Shouldn't things land in master upstream before they are updated in rust master?

RalfJ (Dec 07 2018 at 10:44, on Zulip):

git version 2.7.4 (comes with Ubuntu 16.04)

yeah that's ancient

RalfJ (Dec 07 2018 at 10:45, on Zulip):

Shouldn't things land in master upstream before they are updated in rust master?

that's not possible if upstream has CI, which is also desirable

RalfJ (Dec 07 2018 at 10:46, on Zulip):

if a change in rustc breaks a tool like miri, you have to land the rustc PR and the miri fix in some order

Jethro (Dec 07 2018 at 10:46, on Zulip):

got it

RalfJ (Dec 07 2018 at 10:46, on Zulip):

and most tools (all, AFAIK) choose to require the tool to build against rustc master or nightly, meaning the rustc PR has to land first

Last update: Nov 22 2019 at 00:25UTC