Stream: general

Topic: skip-llvm-rebuild


Walther (Nov 02 2019 at 17:17, on Zulip):

Working on "Add config option and cli arg for skip-llvm-rebuild" https://github.com/rust-lang/rust/pull/65848
I have a simple question - at src/bootstrap/config.rs i'd love to add config.skip_llvm_rebuild to be set from the bootstrap.py too, as i did the handling of CLI args & toml setting already there. Should I set a new env var for it, or should i plop it in RUSTFLAGS or some such in build_bootstrap(), or something completely different?

In addition to what's visible in the PR, I already locally added the lines necessary to actually skip the LLVM build in native.rs

if builder.config.skip_llvm_rebuild {
            builder.info("Skipping LLVM rebuild");
            return build_llvm_config
        }
Walther (Nov 02 2019 at 22:58, on Zulip):

perhaps ping @Alex Crichton @varkor if you have any thoughts (async is perfectly fine, timezones and all). Thanks! <3

Last update: Nov 20 2019 at 11:30UTC